Merge pull request #1672 from yue9944882/bugfix/defaulting-200-status-code

k8s-ci-robot · web-flow · commit 8b08ec39ab12 · 2021-04-26T10:07:16.000-07:00
Bugfix: Defaulting status code to 200 for succeeding api response
diff --git a/util/src/main/java/io/kubernetes/client/util/generic/KubernetesApiResponse.java b/util/src/main/java/io/kubernetes/client/util/generic/KubernetesApiResponse.java
@@ -15,6 +15,7 @@
 import io.kubernetes.client.common.KubernetesType;
 import io.kubernetes.client.openapi.ApiException;
 import io.kubernetes.client.openapi.models.V1Status;
+import java.net.HttpURLConnection;
 
 public class KubernetesApiResponse<DataType extends KubernetesType> {
 
@@ -25,7 +26,7 @@ public class KubernetesApiResponse<DataType extends KubernetesType> {
   public KubernetesApiResponse(DataType object) {
     this.object = object;
     this.status = null;
-    this.httpStatusCode = -1;
+    this.httpStatusCode = HttpURLConnection.HTTP_OK; // 200
   }
 
   public KubernetesApiResponse(V1Status status, int httpStatusCode) {
@@ -47,7 +48,7 @@ public int getHttpStatusCode() {
   }
 
   public boolean isSuccess() {
-    return this.httpStatusCode < 400;
+    return this.httpStatusCode < HttpURLConnection.HTTP_BAD_REQUEST; // 400
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`import io.kubernetes.client.common.KubernetesType;`
`16`	`16`	`import io.kubernetes.client.openapi.ApiException;`
`17`	`17`	`import io.kubernetes.client.openapi.models.V1Status;`
	`18`	`+import java.net.HttpURLConnection;`
`18`	`19`
`19`	`20`	`public class KubernetesApiResponse<DataType extends KubernetesType> {`
`20`	`21`
`@@ -25,7 +26,7 @@ public class KubernetesApiResponse<DataType extends KubernetesType> {`
`25`	`26`	`public KubernetesApiResponse(DataType object) {`
`26`	`27`	`this.object = object;`
`27`	`28`	`this.status = null;`
`28`		`- this.httpStatusCode = -1;`
	`29`	`+ this.httpStatusCode = HttpURLConnection.HTTP_OK; // 200`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`public KubernetesApiResponse(V1Status status, int httpStatusCode) {`
`@@ -47,7 +48,7 @@ public int getHttpStatusCode() {`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`public boolean isSuccess() {`
`50`		`- return this.httpStatusCode < 400;`
	`51`	`+ return this.httpStatusCode < HttpURLConnection.HTTP_BAD_REQUEST; // 400`
`51`	`52`	`}`
`52`	`53`
`53`	`54`	`/**`