Skip to content

Commit 8bf8727

Browse files
authored
Merge pull request #959 from yue9944882/cleanup/unused-code
Chore: Clean up unused codes
2 parents 3e85577 + 2427699 commit 8bf8727

File tree

5 files changed

+3
-157
lines changed

5 files changed

+3
-157
lines changed

extended/src/main/java/io/kubernetes/client/extended/generic/GenericKubernetesApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
import io.kubernetes.client.openapi.apis.CustomObjectsApi;
1919
import io.kubernetes.client.openapi.models.V1ObjectMeta;
2020
import io.kubernetes.client.openapi.models.V1Status;
21+
import io.kubernetes.client.util.ObjectAccessor;
2122
import io.kubernetes.client.util.PatchUtils;
22-
import io.kubernetes.client.util.Reflect;
2323
import io.kubernetes.client.util.Watch;
2424
import io.kubernetes.client.util.Watchable;
2525
import io.kubernetes.client.util.exception.ObjectMetaReflectException;
@@ -379,7 +379,7 @@ public KubernetesApiResponse<ApiListType> list(String namespace, final ListOptio
379379
public KubernetesApiResponse<ApiType> create(ApiType object, final CreateOptions createOptions) {
380380
V1ObjectMeta objectMeta;
381381
try {
382-
objectMeta = Reflect.objectMetadata(object);
382+
objectMeta = ObjectAccessor.objectMetadata(object);
383383
} catch (ObjectMetaReflectException e) {
384384
throw new IllegalArgumentException("fail to extract object metadata");
385385
}
@@ -425,7 +425,7 @@ public KubernetesApiResponse<ApiType> create(ApiType object, final CreateOptions
425425
public KubernetesApiResponse<ApiType> update(ApiType object, final UpdateOptions updateOptions) {
426426
V1ObjectMeta objectMeta;
427427
try {
428-
objectMeta = Reflect.objectMetadata(object);
428+
objectMeta = ObjectAccessor.objectMetadata(object);
429429
} catch (ObjectMetaReflectException e) {
430430
throw new IllegalArgumentException("fail to extract object metadata");
431431
}

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import static io.kubernetes.client.util.KubeConfig.KUBECONFIG;
2222
import static io.kubernetes.client.util.KubeConfig.KUBEDIR;
2323

24-
import com.google.common.base.Strings;
2524
import io.kubernetes.client.openapi.ApiClient;
2625
import io.kubernetes.client.util.credentials.AccessTokenAuthentication;
2726
import io.kubernetes.client.util.credentials.Authentication;
@@ -38,10 +37,6 @@
3837
import java.nio.charset.StandardCharsets;
3938
import java.nio.file.Files;
4039
import java.nio.file.Paths;
41-
import okhttp3.Interceptor;
42-
import okhttp3.OkHttpClient;
43-
import okhttp3.Request;
44-
import okhttp3.Response;
4540
import org.slf4j.Logger;
4641
import org.slf4j.LoggerFactory;
4742

@@ -52,7 +47,6 @@ public class ClientBuilder {
5247
private String basePath = Config.DEFAULT_FALLBACK_HOST;
5348
private byte[] caCertBytes = null;
5449
private boolean verifyingSsl = true;
55-
private String overridePatchFormat;
5650
private Authentication authentication;
5751

5852
/**
@@ -295,15 +289,6 @@ public ClientBuilder setVerifyingSsl(boolean verifyingSsl) {
295289
return this;
296290
}
297291

298-
public String overridePatchFormat() {
299-
return overridePatchFormat;
300-
}
301-
302-
public ClientBuilder setOverridePatchFormat(String patchFormat) {
303-
this.overridePatchFormat = patchFormat;
304-
return this;
305-
}
306-
307292
public ApiClient build() {
308293
final ApiClient client = new ApiClient();
309294

@@ -333,34 +318,6 @@ public ApiClient build() {
333318
client.setSslCaCert(new ByteArrayInputStream(caCertBytes));
334319
}
335320

336-
if (!Strings.isNullOrEmpty(overridePatchFormat)) {
337-
OkHttpClient withInterceptor =
338-
client
339-
.getHttpClient()
340-
.newBuilder()
341-
.addInterceptor(
342-
new Interceptor() {
343-
@Override
344-
public Response intercept(Chain chain) throws IOException {
345-
Request request = chain.request();
346-
347-
if ("PATCH".equals(request.method())) {
348-
349-
Request newRequest =
350-
request
351-
.newBuilder()
352-
.patch(
353-
new ProxyContentTypeRequestBody(
354-
request.body(), overridePatchFormat))
355-
.build();
356-
return chain.proceed(newRequest);
357-
}
358-
return chain.proceed(request);
359-
}
360-
})
361-
.build();
362-
client.setHttpClient(withInterceptor);
363-
}
364321
return client;
365322
}
366323
}

util/src/main/java/io/kubernetes/client/util/Reflect.java

Lines changed: 0 additions & 27 deletions
This file was deleted.

util/src/test/java/io/kubernetes/client/util/ClientBuilderPatchTest.java

Lines changed: 0 additions & 74 deletions
This file was deleted.

util/src/test/java/io/kubernetes/client/util/ClientBuilderTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
import static org.mockito.Mockito.verify;
2222

2323
import com.google.common.io.Resources;
24-
import io.kubernetes.client.custom.V1Patch;
2524
import io.kubernetes.client.openapi.ApiClient;
26-
import io.kubernetes.client.openapi.ApiException;
2725
import io.kubernetes.client.util.credentials.Authentication;
2826
import java.io.File;
2927
import java.io.IOException;
@@ -178,14 +176,6 @@ public void testSslCertCaBad() throws Exception {
178176
.build();
179177
}
180178

181-
@Test
182-
public void testOverridePatchFormat() throws IOException, ApiException {
183-
final ApiClient client =
184-
new ClientBuilder()
185-
.setOverridePatchFormat(V1Patch.PATCH_FORMAT_STRATEGIC_MERGE_PATCH)
186-
.build();
187-
}
188-
189179
@Test
190180
public void testHomeDirPreferredOverKubeConfig() throws Exception {
191181
environmentVariables.set("HOME", HOME_PATH);

0 commit comments

Comments
 (0)