Skip to content

Commit 9e4ffdf

Browse files
Address code review feedback - improve exception handling and remove Thread.yield
Co-authored-by: brendandburns <[email protected]>
1 parent 5b853d5 commit 9e4ffdf

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

extended/src/test/java/io/kubernetes/client/extended/event/EventCorrelatorTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,12 @@ void eventCorrelate(
157157
// Using a polling loop instead of a fixed sleep makes the test more robust
158158
long startTime = System.currentTimeMillis();
159159
while (System.currentTimeMillis() - startTime < 100) {
160-
Thread.sleep(10);
160+
try {
161+
Thread.sleep(10);
162+
} catch (InterruptedException e) {
163+
Thread.currentThread().interrupt();
164+
throw e;
165+
}
161166
}
162167
OffsetDateTime now = OffsetDateTime.now();
163168
newEvent.setFirstTimestamp(now);

spring/src/test/java/io/kubernetes/client/spring/extended/controller/KubernetesReconcilerCreatorTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,12 @@ void simplePodController() throws InterruptedException {
198198
WorkQueue<Request> workQueue = ((DefaultController) testController).getWorkQueue();
199199
long deadline = System.currentTimeMillis() + 2000; // 2 second timeout
200200
while (workQueue.length() == 0 && System.currentTimeMillis() < deadline) {
201-
Thread.sleep(50);
201+
try {
202+
Thread.sleep(50);
203+
} catch (InterruptedException e) {
204+
Thread.currentThread().interrupt();
205+
throw e;
206+
}
202207
}
203208

204209
assertThat(workQueue.length()).isEqualTo(1);

util/src/test/java/io/kubernetes/client/PortForwardTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,6 @@ void brokenPortPassing() throws IOException, InterruptedException {
187187
synchronized (block) {
188188
t.start();
189189
initStarted.await();
190-
// Give init() a moment to process the message
191-
Thread.yield();
192190
handler.close();
193191
block.wait();
194192
}

0 commit comments

Comments
 (0)