Skip to content

Commit af94a84

Browse files
author
Lewis Headden
committed
getBigDecimal -> getNumber
1 parent 924458f commit af94a84

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

kubernetes/src/main/java/io/kubernetes/client/custom/Quantity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public Quantity(final BigDecimal number, final Format format) {
3333
this.format = format;
3434
}
3535

36-
public BigDecimal getBigDecimal() {
36+
public BigDecimal getNumber() {
3737
return number;
3838
}
3939

kubernetes/src/main/java/io/kubernetes/client/custom/QuantityFormatter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public String format(final Quantity quantity) {
3737
return toBase10String(quantity);
3838
case BINARY_SI:
3939
if (isFractional(quantity)) {
40-
return toBase10String(new Quantity(quantity.getBigDecimal(), Quantity.Format.DECIMAL_SI));
40+
return toBase10String(new Quantity(quantity.getNumber(), Quantity.Format.DECIMAL_SI));
4141
}
4242
return toBase1024String(quantity);
4343
default:
@@ -46,19 +46,19 @@ public String format(final Quantity quantity) {
4646
}
4747

4848
private boolean isFractional(Quantity quantity) {
49-
return quantity.getBigDecimal().scale() > 0;
49+
return quantity.getNumber().scale() > 0;
5050
}
5151

5252
private String toBase1024String(final Quantity quantity) {
53-
final BigDecimal amount = quantity.getBigDecimal();
53+
final BigDecimal amount = quantity.getNumber();
5454
final long value = amount.unscaledValue().longValue();
5555
final int exponent = -amount.scale();
5656
final Pair<Long, Integer> resultAndTimes = removeFactorsForBase(value, 1024);
5757
return resultAndTimes.getLeft() + new SuffixFormatter().format(quantity.getFormat(), exponent + resultAndTimes.getRight() * 10);
5858
}
5959

6060
private String toBase10String(final Quantity quantity) {
61-
final BigDecimal amount = quantity.getBigDecimal();
61+
final BigDecimal amount = quantity.getNumber();
6262
final long value = amount.unscaledValue().longValue();
6363
final int exponent = -amount.scale();
6464
final Pair<Long, Integer> resultAndTimes = removeFactorsForBase(value, 10);

kubernetes/src/test/java/io/kubernetes/client/custom/QuantityFormatterTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,49 +13,49 @@ public class QuantityFormatterTest {
1313
public void testParsePlain() {
1414
final Quantity quantity = new QuantityFormatter().parse("1");
1515
assertThat(quantity.getFormat(), is(Quantity.Format.DECIMAL_SI));
16-
assertThat(quantity.getBigDecimal(), is(BigDecimal.valueOf(1)));
16+
assertThat(quantity.getNumber(), is(BigDecimal.valueOf(1)));
1717
}
1818

1919
@Test
2020
public void testParseFractional() {
2121
final Quantity quantity = new QuantityFormatter().parse("0.001");
2222
assertThat(quantity.getFormat(), is(Quantity.Format.DECIMAL_SI));
23-
assertThat(quantity.getBigDecimal(), is(BigDecimal.valueOf(0.001)));
23+
assertThat(quantity.getNumber(), is(BigDecimal.valueOf(0.001)));
2424
}
2525

2626
@Test
2727
public void testParseFractionalUnit() {
2828
final Quantity quantity = new QuantityFormatter().parse("0.001m");
2929
assertThat(quantity.getFormat(), is(Quantity.Format.DECIMAL_SI));
30-
assertThat(quantity.getBigDecimal(), is(new BigDecimal("0.000001")));
30+
assertThat(quantity.getNumber(), is(new BigDecimal("0.000001")));
3131
}
3232

3333
@Test
3434
public void testParseBinarySi() {
3535
final Quantity quantity = new QuantityFormatter().parse("1Ki");
3636
assertThat(quantity.getFormat(), is(Quantity.Format.BINARY_SI));
37-
assertThat(quantity.getBigDecimal(), is(BigDecimal.valueOf(1024)));
37+
assertThat(quantity.getNumber(), is(BigDecimal.valueOf(1024)));
3838
}
3939

4040
@Test
4141
public void testParseLargeNumeratorBinarySi() {
4242
final Quantity quantity = new QuantityFormatter().parse("32Mi");
4343
assertThat(quantity.getFormat(), is(Quantity.Format.BINARY_SI));
44-
assertThat(quantity.getBigDecimal(), is(BigDecimal.valueOf(2).pow(20).multiply(BigDecimal.valueOf(32))));
44+
assertThat(quantity.getNumber(), is(BigDecimal.valueOf(2).pow(20).multiply(BigDecimal.valueOf(32))));
4545
}
4646

4747
@Test
4848
public void testParseExponent() {
4949
final Quantity quantity = new QuantityFormatter().parse("1e3");
5050
assertThat(quantity.getFormat(), is(Quantity.Format.DECIMAL_EXPONENT));
51-
assertThat(quantity.getBigDecimal(), is(BigDecimal.valueOf(1000)));
51+
assertThat(quantity.getNumber(), is(BigDecimal.valueOf(1000)));
5252
}
5353

5454
@Test
5555
public void testParseNegativeExponent() {
5656
final Quantity quantity = new QuantityFormatter().parse("1e-3");
5757
assertThat(quantity.getFormat(), is(Quantity.Format.DECIMAL_EXPONENT));
58-
assertThat(quantity.getBigDecimal(), is(BigDecimal.valueOf(0.001)));
58+
assertThat(quantity.getNumber(), is(BigDecimal.valueOf(0.001)));
5959
}
6060

6161
@Test(expected = QuantityFormatException.class)

0 commit comments

Comments
 (0)