Skip to content

Commit b9be575

Browse files
authored
Merge pull request #1381 from sarveshkaushal/master
[Code cleanup] making nested class static
2 parents d6d5c5d + 36c3c3a commit b9be575

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

extended/src/main/java/io/kubernetes/client/extended/event/legacy/EventAggregator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ record = this.spammingCache.get(aggregatedKey, AggregatedRecord::new);
8888
return new MutablePair<>(aggregatedEvent, aggregatedKey);
8989
}
9090

91-
private class AggregatedRecord {
91+
private static class AggregatedRecord {
9292
private Set<String> localKeys = new HashSet<>();
9393
private DateTime lastTimestamp;
9494

extended/src/main/java/io/kubernetes/client/extended/event/legacy/EventLogger.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public void updateState(CoreV1Event event) {
6767
this.eventCache.put(key, log);
6868
}
6969

70-
private class EventLog {
70+
private static class EventLog {
7171
private Integer count;
7272
private DateTime firstTimestamp;
7373
private String name;

extended/src/main/java/io/kubernetes/client/extended/workqueue/DefaultDelayingQueue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ private void insert(
125125
}
126126

127127
// WaitForEntry holds the data to add and the time it should be added.
128-
private class WaitForEntry<T> implements Delayed {
128+
private static class WaitForEntry<T> implements Delayed {
129129

130130
private WaitForEntry(T data, Temporal readyAtMillis) {
131131
this.data = data;

extended/src/test/java/io/kubernetes/client/extended/controller/ControllerManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public void testControllerStartShutdown() {
3535
assertTrue(dummy2.stopped);
3636
}
3737

38-
class DummyController implements Controller {
38+
static class DummyController implements Controller {
3939

4040
private boolean started;
4141
private boolean stopped;

spring/src/test/java/io/kubernetes/client/spring/extended/controller/KubernetesInformerCreatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public KubernetesInformerConfigurer kubernetesInformerConfigurer(
9191
apiVersion = "v1",
9292
resourcePlural = "configmaps")),
9393
})
94-
class TestSharedInformerFactory extends SharedInformerFactory {}
94+
static class TestSharedInformerFactory extends SharedInformerFactory {}
9595
}
9696

9797
@Autowired private SharedInformerFactory informerFactory;

util/src/test/java/io/kubernetes/client/WebsocketStreamHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public void testHandlerSendingLargeData() throws IOException {
122122
assertArrayEquals(output, mockWebSocket.data);
123123
}
124124

125-
private class MockWebSocket implements WebSocket {
125+
private static class MockWebSocket implements WebSocket {
126126
byte[] data;
127127
private boolean closed = false;
128128

util/src/test/java/io/kubernetes/client/util/KubeConfigTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ public void testNullNamespace() {
221221
assertNull(config.getNamespace());
222222
}
223223

224-
class FakeAuthenticator implements Authenticator {
224+
static class FakeAuthenticator implements Authenticator {
225225
public String token;
226226
public String refresh;
227227
public boolean expired;

0 commit comments

Comments
 (0)