improving test coverage using wiremock

Author: yue9944882

util/src/test/java/io/kubernetes/client/informer/cache/ControllerTest.java

@@ -2,16 +2,13 @@
 
 import static org.junit.Assert.*;
 
-import io.kubernetes.client.ApiException;
 import io.kubernetes.client.informer.EventType;
 import io.kubernetes.client.informer.ListerWatcher;
 import io.kubernetes.client.models.V1ListMeta;
 import io.kubernetes.client.models.V1ObjectMeta;
 import io.kubernetes.client.models.V1Pod;
 import io.kubernetes.client.models.V1PodList;
-import io.kubernetes.client.util.CallGeneratorParams;
 import io.kubernetes.client.util.Watch;
-import io.kubernetes.client.util.Watchable;
 import java.util.Arrays;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -37,24 +34,10 @@ public void testControllerProcessDeltas() throws InterruptedException {
         new DeltaFIFO<>(Cache::deletionHandlingMetaNamespaceKeyFunc, new Cache());
 
     AtomicBoolean runOnce = new AtomicBoolean(false);
-    ListerWatcher<V1Pod, V1PodList> listerWatcher =
-        new ListerWatcher<V1Pod, V1PodList>() {
-          @Override
-          public V1PodList list(CallGeneratorParams params) throws ApiException {
-            return podList;
-          }
 
-          @Override
-          public Watchable<V1Pod> watch(CallGeneratorParams params) throws ApiException {
-            if (!runOnce.get()) {
-              runOnce.set(true);
-              return new MockWatch<V1Pod>(
-                  new Watch.Response<V1Pod>(EventType.MODIFIED.name(), foo3));
-            } else {
-              return new MockWatch<V1Pod>();
-            }
-          }
-        };
+    ListerWatcher<V1Pod, V1PodList> listerWatcher =
+        new MockRunOnceListerWatcher<V1Pod, V1PodList>(
+            podList, new Watch.Response<V1Pod>(EventType.MODIFIED.name(), foo3));
 
     Controller<V1Pod, V1PodList> controller =
         new Controller<>(

util/src/test/java/io/kubernetes/client/informer/cache/MockRunOnceListerWatcher.java

@@ -0,0 +1,48 @@
+package io.kubernetes.client.informer.cache;
+
+import io.kubernetes.client.ApiException;
+import io.kubernetes.client.informer.ListerWatcher;
+import io.kubernetes.client.util.CallGeneratorParams;
+import io.kubernetes.client.util.Watch;
+import io.kubernetes.client.util.Watchable;
+
+public class MockRunOnceListerWatcher<ApiType, ApiListType>
+    implements ListerWatcher<ApiType, ApiListType> {
+
+  private ApiListType list;
+  private Watch.Response<ApiType>[] events;
+
+  private boolean listExecuted = false;
+  private boolean watchExecuted = false;
+
+  public MockRunOnceListerWatcher(ApiListType list, Watch.Response<ApiType>... events) {
+    this.list = list;
+    this.events = events;
+  }
+
+  @Override
+  public ApiListType list(CallGeneratorParams params) throws ApiException {
+    if (!listExecuted) {
+      listExecuted = true;
+      return list;
+    }
+    try {
+      Thread.sleep(100000);
+    } catch (InterruptedException e) {
+    }
+    return null;
+  }
+
+  @Override
+  public Watchable<ApiType> watch(CallGeneratorParams params) throws ApiException {
+    if (!watchExecuted) {
+      watchExecuted = true;
+      return new MockWatch<>(events);
+    }
+    try {
+      Thread.sleep(100000);
+    } catch (InterruptedException e) {
+    }
+    return new MockWatch<>();
+  }
+}