Skip to content

Commit d680d1f

Browse files
committed
codegen container should abort upon any error
1 parent 02c8b32 commit d680d1f

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

client-java-contrib/cert-manager/update.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ docker run \
2525
-v "$(pwd)":"$(pwd)" \
2626
-ti \
2727
--network host \
28-
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.1 \
28+
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.2 \
2929
/generate.sh \
3030
-u https://github.com/jetstack/cert-manager/releases/download/v0.16.1/cert-manager.crds.yaml \
3131
-n io.cert-manager \

client-java-contrib/generate.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,16 @@ while getopts 'u:n:p:o:' flag; do
4141
esac
4242
done
4343

44+
set -e
45+
4446
# create a KinD cluster on the host
4547
kind create cluster
4648

4749
# install CRDs to the KinD cluster and dump the swagger spec
4850
for url in "${CRD_URLS[@]}"; do
49-
kubectl apply -f "$url"
51+
if [[ ! -z $url ]]; then
52+
kubectl apply -f "$url"
53+
fi
5054
done
5155

5256
sleep 5
@@ -58,10 +62,12 @@ kubectl get crd -o name \
5862
do
5963
if [[ $(kubectl get $L -o jsonpath='{.status.conditions[?(@.type=="NonStructuralSchema")].status}') == "True" ]]; then
6064
echo "$L failed publishing openapi schema because it's attached non-structral-schema condition."
65+
kind delete cluster
6166
exit 1
6267
fi
6368
if [[ $(kubectl get $L -o jsonpath='{.spec.preserveUnknownFields}') == "true" ]]; then
6469
echo "$L failed publishing openapi schema because it explicitly disabled unknown fields pruning."
70+
kind delete cluster
6571
exit 1
6672
fi
6773
echo "$L successfully installed"

client-java-contrib/prometheus-operator/update.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ docker run \
2525
-v "$(pwd)":"$(pwd)" \
2626
-ti \
2727
--network host \
28-
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.1 \
28+
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.2 \
2929
/generate.sh \
3030
-u https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.38.1/example/prometheus-operator-crd/monitoring.coreos.com_alertmanagers.yaml \
3131
-u https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.38.1/example/prometheus-operator-crd/monitoring.coreos.com_thanosrulers.yaml \

docs/generate-model-from-third-party-resources.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ docker run \
5353
-v "$(pwd)":"$(pwd)" \
5454
-ti \
5555
--network host \
56-
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.1 \
56+
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.2 \
5757
/generate.sh \
5858
-u https://gist.githubusercontent.com/yue9944882/266fee8e95c2f15a93778263633e72ed/raw/be12c13379eeed13d2532cb65da61fffb19ee3e7/crontab-crd.yaml \
5959
-n com.example.stable \
@@ -84,7 +84,7 @@ docker run \
8484
-v "$(pwd)":"$(pwd)" \
8585
-ti \
8686
--network host \
87-
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.1 \
87+
docker.pkg.github.com/kubernetes-client/java/crd-model-gen:v1.0.2 \
8888
/generate.sh \
8989
-u $LOCAL_MANIFEST_FILE \
9090
-n com.example.stable \

0 commit comments

Comments
 (0)