Merge pull request #1285 from yue9944882/bugfix/kubectl-replace-verify

Bugfix(kubectl): Name argument is not required for kubectl replace

Author: k8s-ci-robot

e2e/src/test/groovy/io/kubernetes/client/e2e/kubectl/KubectlApplyTest.groovy

@@ -0,0 +1,78 @@
+package io.kubernetes.client.e2e.kubectl
+
+import io.kubernetes.client.extended.kubectl.Kubectl
+import io.kubernetes.client.extended.kubectl.exception.KubectlException
+import io.kubernetes.client.openapi.ApiException
+import io.kubernetes.client.openapi.models.V1Namespace
+import io.kubernetes.client.openapi.models.V1ObjectMeta
+import io.kubernetes.client.util.ClientBuilder
+import spock.lang.Specification
+import spock.util.concurrent.PollingConditions
+
+class KubectlNamespaceTest extends Specification {
+
+    def "Kubectl manipulating namespace should work"() {
+        given:
+        def apiClient = ClientBuilder.defaultClient();
+
+        when:
+        def createdNamespace = Kubectl.create(V1Namespace.class)
+                .apiClient(apiClient)
+                .resource(new V1Namespace()
+                        .apiVersion("v1")
+                        .metadata(
+                                new V1ObjectMeta()
+                                        .name("foo")))
+                .execute()
+        then:
+        createdNamespace != null
+        Kubectl.get(V1Namespace.class)
+                .apiClient(apiClient)
+                .name("foo")
+                .execute() != null
+
+        when:
+        def appliedNamespace = Kubectl.apply(V1Namespace.class)
+                .apiClient(apiClient)
+                .resource(new V1Namespace()
+                        .apiVersion("v1")
+                        .kind("Namespace")
+                        .metadata(new V1ObjectMeta()
+                                .name("foo")
+                                .putAnnotationsItem("k", "v")))
+                .execute()
+        then:
+        appliedNamespace != null
+        Kubectl.get(V1Namespace.class)
+                .apiClient(apiClient)
+                .name("foo")
+                .execute().metadata.getAnnotations().get("k") == "v"
+
+        when:
+        def replacedNamespace = Kubectl.replace(V1Namespace.class)
+                .apiClient(apiClient)
+                .resource(new V1Namespace()
+                        .apiVersion("v1")
+                        .kind("Namespace")
+                        .metadata(new V1ObjectMeta()
+                                .name("foo")
+                                .putAnnotationsItem("k", "v2")))
+                .execute()
+        then:
+        replacedNamespace != null
+        Kubectl.get(V1Namespace.class)
+                .apiClient(apiClient)
+                .name("foo")
+                .execute().metadata.getAnnotations().get("k") == "v2"
+
+        when:
+        def deletedNamespace = Kubectl.delete(V1Namespace.class)
+                .apiClient(apiClient)
+                .name("foo")
+                .execute()
+        then:
+        deletedNamespace != null
+
+    }
+
+}

e2e/src/test/groovy/io/kubernetes/client/e2e/kubectl/KubectlCreateTest.groovy

@@ -23,7 +23,7 @@ public class KubectlReplace<ApiType extends KubernetesObject>
     extends Kubectl.ResourceBuilder<ApiType, KubectlReplace<ApiType>>
     implements Kubectl.Executable<ApiType> {
   ApiType updateObject;
-  UpdateOptions options;
+  UpdateOptions options = new UpdateOptions();
 
   KubectlReplace(Class<ApiType> apiTypeClass) {
     super(apiTypeClass);
@@ -69,9 +69,6 @@ public boolean isNamespaced(Class<ApiType> apiTypeClass) {
   }
 
   private void verifyArguments() throws KubectlException {
-    if (null == name) {
-      throw new KubectlException("missing name argument");
-    }
     if (null == updateObject) {
       throw new KubectlException("missing new resource");
     }