Support tls-server-name field from kubeconfig for SNI #4402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client fails TLS verification when kubeconfig specifies a
tls-server-namedifferent from the server URL hostname. This is common with Teleport-generated configs where the certificate CN/SAN doesn't match the proxy IP.Changes
getTlsServerName()to readtls-server-namefrom cluster configtlsServerNamefield and customHostnameVerifierthat delegates toOkHostnameVerifier.INSTANCE.verify(tlsServerName, session)instead of verifying against URL hostnametls-server-namefrom KubeConfig through to ApiClientExample
The client now verifies the certificate against
my-cluster.example.cominstead of192.168.1.1, allowing successful TLS handshake with mismatched hostnames.Resolves issue where workaround required
insecure-skip-tls-verify: true.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.