test: add test for ListWatch labelSelector query param

Author: StefanCenusa

src/cache_test.ts

@@ -1,4 +1,5 @@
 import { expect, use } from 'chai';
+import * as request from 'request';
 import chaiAsPromised = require('chai-as-promised');
 
 import * as mock from 'ts-mockito';
@@ -9,18 +10,46 @@ import { EventEmitter } from 'ws';
 
 import { V1Namespace, V1NamespaceList, V1ObjectMeta, V1Pod, V1ListMeta } from './api';
 import { deleteObject, ListWatch, deleteItems } from './cache';
+import { KubeConfig } from './config';
+import { Cluster, Context, User } from './config_types';
 import { ADD, UPDATE, DELETE, ERROR, ListPromise, CHANGE } from './informer';
 
 use(chaiAsPromised);
 
-import { RequestResult, Watch } from './watch';
+import { DefaultRequest, RequestResult, Watch } from './watch';
 
 // Object replacing real Request object in the test
 class FakeRequest extends EventEmitter implements RequestResult {
     pipe(stream: Duplex): void {}
     abort() {}
 }
 
+const server = 'foo.company.com';
+
+const fakeConfig: {
+    clusters: Cluster[];
+    contexts: Context[];
+    users: User[];
+} = {
+    clusters: [
+        {
+            name: 'cluster',
+            server,
+        } as Cluster,
+    ],
+    contexts: [
+        {
+            cluster: 'cluster',
+            user: 'user',
+        } as Context,
+    ],
+    users: [
+        {
+            name: 'user',
+        } as User,
+    ],
+};
+
 describe('ListWatchCache', () => {
     it('should throw on unknown update', () => {
         const fake = mock.mock(Watch);
@@ -1022,52 +1051,73 @@ describe('ListWatchCache', () => {
         ).once();
         expect(errorEmitted).to.equal(true);
     });
-});
 
-describe('delete items', () => {
-    it('should remove correctly', () => {
-        const listA: V1Pod[] = [
+    it('should send label selector', async () => {
+        const APP_LABEL_SELECTOR = 'app=foo';
+
+        const list: V1Namespace[] = [
             {
                 metadata: {
                     name: 'name1',
-                    namespace: 'ns1',
+                    labels: {
+                        app: 'foo',
+                    },
                 } as V1ObjectMeta,
-            } as V1Pod,
+            } as V1Namespace,
             {
                 metadata: {
                     name: 'name2',
-                    namespace: 'ns2',
+                    labels: {
+                        app: 'foo',
+                    },
                 } as V1ObjectMeta,
-            } as V1Pod,
-        ];
-        const listB: V1Pod[] = [
-            {
-                metadata: {
-                    name: 'name1',
-                    namespace: 'ns1',
-                } as V1ObjectMeta,
-            } as V1Pod,
-            {
-                metadata: {
-                    name: 'name3',
-                    namespace: 'ns3',
-                } as V1ObjectMeta,
-            } as V1Pod,
-        ];
-        const expected: V1Pod[] = [
-            {
-                metadata: {
-                    name: 'name1',
-                    namespace: 'ns1',
-                } as V1ObjectMeta,
-            } as V1Pod,
+            } as V1Namespace,
         ];
+        const listObj = {
+            metadata: {
+                resourceVersion: '12345',
+            } as V1ListMeta,
+            items: list,
+        } as V1NamespaceList;
 
-        const output = deleteItems(listA, listB);
-        expect(output).to.deep.equal(expected);
+        const listFn: ListPromise<V1Namespace> = function(): Promise<{
+            response: http.IncomingMessage;
+            body: V1NamespaceList;
+        }> {
+            return new Promise<{ response: http.IncomingMessage; body: V1NamespaceList }>(
+                (resolve, reject) => {
+                    resolve({ response: {} as http.IncomingMessage, body: listObj });
+                },
+            );
+        };
+
+        const kc = new KubeConfig();
+        Object.assign(kc, fakeConfig);
+        const fakeRequestor = mock.mock(DefaultRequest);
+        const watch = new Watch(kc, mock.instance(fakeRequestor));
+
+        const fakeRequest = new FakeRequest();
+        mock.when(fakeRequestor.webRequest(mock.anything())).thenReturn(fakeRequest);
+
+        const informer = new ListWatch(
+            '/some/path',
+            watch,
+            listFn,
+            false,
+            APP_LABEL_SELECTOR,
+        );
+
+        await informer.start();
+
+        mock.verify(fakeRequestor.webRequest(mock.anything()));
+        const [opts] = mock.capture(fakeRequestor.webRequest).last();
+        const reqOpts: request.OptionsWithUri = opts as request.OptionsWithUri;
+        expect(reqOpts.qs.labelSelector).to.equal(APP_LABEL_SELECTOR);
     });
+});
 
-    it('should callback correctly', () => {
+describe('delete items', () => {
+    it('should remove correctly', () => {
         const listA: V1Pod[] = [
             {
                 metadata: {
@@ -1099,12 +1149,54 @@ describe('delete items', () => {
         const expected: V1Pod[] = [
             {
                 metadata: {
-                    name: 'name2',
-                    namespace: 'ns2',
+                    name: 'name1',
+                    namespace: 'ns1',
                 } as V1ObjectMeta,
             } as V1Pod,
         ];
-        const pods: V1Pod[] = [];
+
+            const output = deleteItems(listA, listB);
+            expect(output).to.deep.equal(expected);
+        });
+
+        it('should callback correctly', () => {
+            const listA: V1Pod[] = [
+                {
+                    metadata: {
+                        name: 'name1',
+                        namespace: 'ns1',
+                    } as V1ObjectMeta,
+                } as V1Pod,
+                {
+                    metadata: {
+                        name: 'name2',
+                        namespace: 'ns2',
+                    } as V1ObjectMeta,
+                } as V1Pod,
+            ];
+            const listB: V1Pod[] = [
+                {
+                    metadata: {
+                        name: 'name1',
+                        namespace: 'ns1',
+                    } as V1ObjectMeta,
+                } as V1Pod,
+                {
+                    metadata: {
+                        name: 'name3',
+                        namespace: 'ns3',
+                    } as V1ObjectMeta,
+                } as V1Pod,
+            ];
+            const expected: V1Pod[] = [
+                {
+                    metadata: {
+                        name: 'name2',
+                        namespace: 'ns2',
+                    } as V1ObjectMeta,
+                } as V1Pod,
+            ];
+            const pods: V1Pod[] = [];
 
         deleteItems(listA, listB, [(obj: V1Pod) => pods.push(obj)]);
         expect(pods).to.deep.equal(expected);