Add better unit testing for requests.

Author: brendandburns

package-lock.json

@@ -65,13 +65,16 @@
   },
   "devDependencies": {
     "@types/chai": "^4.1.6",
+    "@types/chai-as-promised": "^7.1.0",
     "@types/mocha": "^5.2.5",
     "@types/mock-fs": "^3.6.30",
     "@types/stream-buffers": "^3.0.3",
     "chai": "^4.2.0",
+    "chai-as-promised": "^7.1.1",
     "jasmine": "^3.3.0",
     "mocha": "^5.2.0",
     "mock-fs": "^4.7.0",
+    "nock": "^10.0.6",
     "nyc": "^13.3.0",
     "prettier": "~1.16.4",
     "source-map-support": "^0.5.9",

package.json

@@ -3,7 +3,7 @@ import * as https from 'https';
 import { dirname, join } from 'path';
 
 import { expect } from 'chai';
-import mockfs = require('mock-fs');
+import mockfs from 'mock-fs';
 import * as requestlib from 'request';
 
 import { Core_v1Api } from './api';
@@ -30,20 +30,24 @@ function validateFileLoad(kc: KubeConfig) {
     expect(cluster2.skipTLSVerify).to.equal(true);
 
     // check users
-    expect(kc.users.length).to.equal(2, 'there are 2 users');
+    expect(kc.users.length).to.equal(3, 'there are 3 users');
     const user1 = kc.users[0];
     const user2 = kc.users[1];
+    const user3 = kc.users[2];
     expect(user1.name).to.equal('user1');
     expect(user1.certData).to.equal('VVNFUl9DQURBVEE=');
     expect(user1.keyData).to.equal('VVNFUl9DS0RBVEE=');
     expect(user2.name).to.equal('user2');
     expect(user2.certData).to.equal('VVNFUjJfQ0FEQVRB');
     expect(user2.keyData).to.equal('VVNFUjJfQ0tEQVRB');
-
+    expect(user3.name).to.equal('user3');
+    expect(user3.username).to.equal('foo');
+    expect(user3.password).to.equal('bar');
     // check contexts
-    expect(kc.contexts.length).to.equal(2, 'there are two contexts');
+    expect(kc.contexts.length).to.equal(3, 'there are three contexts');
     const context1 = kc.contexts[0];
     const context2 = kc.contexts[1];
+    const context3 = kc.contexts[2];
     expect(context1.name).to.equal('context1');
     expect(context1.user).to.equal('user1');
     expect(context1.namespace).to.equal(undefined);
@@ -52,6 +56,9 @@ function validateFileLoad(kc: KubeConfig) {
     expect(context2.user).to.equal('user2');
     expect(context2.namespace).to.equal('namespace2');
     expect(context2.cluster).to.equal('cluster2');
+    expect(context3.name).to.equal('passwd');
+    expect(context3.user).to.equal('user3');
+    expect(context3.cluster).to.equal('cluster2');
 
     expect(kc.getCurrentContext()).to.equal('context2');
 }
@@ -199,6 +206,26 @@ describe('KubeConfig', () => {
                 rejectUnauthorized: false,
             });
         });
+        it('should apply password', () => {
+            const kc = new KubeConfig();
+            kc.loadFromFile(kcFileName);
+            kc.setCurrentContext('passwd');
+
+            const opts: requestlib.Options = {
+                url: 'https://company.com',
+            };
+            kc.applyToRequest(opts);
+            expect(opts).to.deep.equal({
+                ca: new Buffer('CADATA2', 'utf-8'),
+                auth: {
+                    username: 'foo',
+                    password: 'bar',
+                },
+                url: 'https://company.com',
+                strictSSL: false,
+                rejectUnauthorized: false,
+            });
+        });
     });
 
     describe('loadClusterConfigObjects', () => {

src/config_test.ts

@@ -0,0 +1,51 @@
+import { expect, use } from 'chai';
+import chaiAsPromised from 'chai-as-promised';
+import nock from 'nock';
+
+import { Core_v1Api } from './api';
+import { KubeConfig } from './config';
+import { Cluster, User } from './config_types';
+
+use(chaiAsPromised);
+
+describe('FullRequest', () => {
+    describe('getPods', () => {
+        it('should get pods successfully', () => {
+            const kc = new KubeConfig();
+            const cluster = {
+                name: 'foo',
+                server: 'https://nowhere.foo',
+            } as Cluster;
+            const username = 'foo';
+            const password = 'some-password';
+            const user = {
+                name: 'my-user',
+                username,
+                password,
+            } as User;
+
+            kc.loadFromClusterAndUser(cluster, user);
+
+            const k8sApi = kc.makeApiClient(Core_v1Api);
+            const result = {
+                kind: 'PodList',
+                apiVersion: 'v1',
+                items: [],
+            };
+            const auth = Buffer.from(`${username}:${password}`).toString('base64');
+            nock('https://nowhere.foo:443', {
+                reqheaders: {
+                    authorization: `Basic ${auth}`,
+                },
+            })
+                .get('/api/v1/namespaces/default/pods')
+                .reply(200, result);
+
+            const promise = k8sApi.listNamespacedPod('default');
+
+            return expect(promise)
+                .to.eventually.have.property('body')
+                .that.deep.equals(result);
+        });
+    });
+});

src/integration_test.ts

@@ -20,6 +20,10 @@ contexts:
     namespace: namespace2
     user: user2
   name: context2
+- context:
+    cluster: cluster2
+    user: user3
+  name: passwd
 
 current-context: context2 
 kind: Config
@@ -32,4 +36,8 @@ users:
 - name: user2
   user:
     client-certificate-data: VVNFUjJfQ0FEQVRB
-    client-key-data: VVNFUjJfQ0tEQVRB
+    client-key-data: VVNFUjJfQ0tEQVRB
+- name: user3
+  user:
+    username: foo
+    password: bar