fix: switch from shelljs to execa to avoid issues in Electron

Author: edvald

node-client/package-lock.json

@@ -47,6 +47,7 @@
     "base-64": "^0.1.0",
     "bluebird": "^3.5.2",
     "byline": "^5.0.0",
+    "execa": "^1.0.0",
     "js-yaml": "^3.12.0",
     "jsonpath": "^1.0.0",
     "request": "^2.88.0",
@@ -59,6 +60,7 @@
     "@types/base-64": "^0.1.2",
     "@types/bluebird": "^3.5.24",
     "@types/chai": "^4.1.6",
+    "@types/execa": "^0.9.0",
     "@types/js-yaml": "^3.11.2",
     "@types/mocha": "^5.2.5",
     "@types/mock-fs": "^3.6.30",

node-client/package.json

@@ -3,10 +3,10 @@ import https = require('https');
 import path = require('path');
 
 import base64 = require('base-64');
+import execa = require('execa');
 import yaml = require('js-yaml');
 import jsonpath = require('jsonpath');
 import request = require('request');
-import shelljs = require('shelljs');
 
 import api = require('./api');
 import { Cluster, Context, newClusters, newContexts, newUsers, User } from './config_types';
@@ -273,15 +273,17 @@ export class KubeConfig {
                 const expiration = Date.parse(expiry);
                 if (expiration < Date.now()) {
                     if (config['cmd-path']) {
-                        let cmd = '"' + config['cmd-path'] + '"';
-                        if (config['cmd-args']) {
-                            cmd = cmd + ' ' + config['cmd-args'];
-                        }
+                        const args = config['cmd-args'] ? [config['cmd-args']] : [];
                         // TODO: Cache to file?
-                        const result = shelljs.exec(cmd, { silent: true });
-                        if (result.code !== 0) {
-                            throw new Error('Failed to refresh token: ' + result.stderr);
+                        // TODO: do this asynchronously
+                        let result: execa.ExecaReturns;
+
+                        try {
+                            result = execa.sync(config['cmd-path'], args);
+                        } catch (err) {
+                            throw new Error('Failed to refresh token: ' + err.message);
                         }
+
                         const output = result.stdout.toString();
                         const resultObj = JSON.parse(output);
 

node-client/src/config.ts

@@ -536,7 +536,7 @@ describe('KubeConfig', () => {
                 } as User);
             const opts = {} as requestlib.Options;
             expect(() => config.applyToRequest(opts)).to.throw(
-                'Failed to refresh token: /bin/sh: 1: non-existent-command: not found');
+                'Failed to refresh token: spawnSync non-existent-command ENOENT');
         });
 
         it('should exec with expired token', () => {
@@ -550,7 +550,7 @@ describe('KubeConfig', () => {
                         config: {
                             'expiry': 'Aug 24 07:32:05 PDT 2017',
                             'cmd-path': 'echo',
-                            'cmd-args': `'${responseStr}'`,
+                            'cmd-args': `${responseStr}`,
                             'token-key': '{.token.accessToken}',
                         },
                     },