reject when fetch fails

Author: feloy

src/health.ts

@@ -39,17 +39,17 @@ export class Health {
             const status = response.status;
             if (status === 200) {
                 return true;
-            } else if (status === 404) {
+            }
+            if (status === 404) {
                 if (path === '/healthz') {
                     // /livez/readyz return 404 and healthz also returns 404, let's consider it is live
                     return true;
                 }
                 return this.healthz(opts);
-            } else {
-                return false;
             }
-        } catch {
             return false;
+        } catch {
+            throw new Error('Error occurred in health request');
         }
     }
 }

src/health_test.ts

@@ -124,7 +124,7 @@ describe('Health', () => {
             scope.done();
         });
 
-        it('should return false when fetch throws an error', async () => {
+        it('should throw an error when fetch throws an error', async () => {
             const kc = new KubeConfig();
             const cluster = {
                 name: 'foo',
@@ -141,8 +141,7 @@ describe('Health', () => {
             scope.get('/livez').replyWithError(new Error('an error'));
             const health = new Health(kc);
 
-            const r = await health.livez({});
-            expect(r).to.be.false;
+            await expect(health.livez({})).to.be.rejectedWith('Error occurred in health request');
             scope.done();
         });
     });