update to strictequals, imports, and remove mixed then/await

Author: davidgamero

examples/typescript/patch/patch-example.ts

@@ -1,5 +1,4 @@
-import { CoreV1Api, KubeConfig, setHeaderOptions } from '@kubernetes/client-node';
-import { PatchStrategy } from '@kubernetes/client-node/patch';
+import { CoreV1Api, KubeConfig, setHeaderOptions, PatchStrategy } from '@kubernetes/client-node';
 
 const kc = new KubeConfig();
 kc.loadFromDefault();

src/middleware_test.ts

@@ -8,10 +8,9 @@ describe('Middleware', async () => {
             const reqContext = new RequestContext('http://nowhere.com', HttpMethod.GET);
             deepStrictEqual(reqContext.getHeaders(), {});
             const headerMiddleware = setHeaderMiddleware('test-key', 'test-value');
-            const postMiddlewareRequest = await headerMiddleware.pre(reqContext);
-            await postMiddlewareRequest.toPromise().then((request) => {
-                deepStrictEqual(request.getHeaders(), { 'test-key': 'test-value' });
-            });
+            const postMiddlewareRequestObservable = await headerMiddleware.pre(reqContext);
+            const postMiddlewareRequest = await postMiddlewareRequestObservable.toPromise();
+            deepStrictEqual(postMiddlewareRequest.getHeaders(), { 'test-key': 'test-value' });
         });
 
         it('should replace a header if it is already specified', async () => {

src/test/integration/index.ts

@@ -2,4 +2,4 @@ import patchNamespace from './patchNamespace.js';
 
 console.log('Integration testing');
 
-patchNamespace();
+await patchNamespace();

src/test/integration/name.ts

@@ -0,0 +1,7 @@
+/*
+ * This function is used to generate a random name for the resources created in the tests.
+ * This is to avoid conflicts with existing resources.
+ */
+export function generateName(name: string) {
+    return name + '-' + Math.random().toString(36).substring(7);
+}

src/test/integration/patchNamespace.ts

@@ -1,13 +1,14 @@
 import assert, { deepEqual } from 'node:assert';
 import { PatchStrategy, CoreV1Api, KubeConfig, setHeaderOptions, V1Namespace } from '../../index.js';
+import { generateName } from './name.js';
 
 export default async function patchNamespace() {
     const kc = new KubeConfig();
     kc.loadFromDefault();
 
     const coreV1Client = kc.makeApiClient(CoreV1Api);
     let newNS = new V1Namespace();
-    const testNSName = 'integration-test-patch-ns';
+    const testNSName = generateName('patch-ns');
     newNS.metadata = {
         name: testNSName,
         labels: {
@@ -17,8 +18,8 @@ export default async function patchNamespace() {
     console.log(`Creating namespace ${testNSName}`);
     await coreV1Client.createNamespace({ body: newNS });
     newNS = await coreV1Client.readNamespace({ name: testNSName });
-    assert(newNS.metadata?.name === testNSName);
-    deepEqual(newNS.metadata?.labels?.initialLabel, 'initialValue');
+    assert.strictEqual(newNS.metadata?.name, testNSName);
+    assert.strictEqual(newNS.metadata?.labels?.initialLabel, 'initialValue');
     console.log('Namespace created with initial label.');
 
     const patch = [
@@ -41,7 +42,7 @@ export default async function patchNamespace() {
     );
 
     const patchedNS = await coreV1Client.readNamespace({ name: testNSName });
-    deepEqual(patchedNS.metadata?.labels?.foo, 'bar');
-    deepEqual(patchedNS.metadata?.labels?.initialLabel, undefined);
+    assert.strictEqual(patchedNS.metadata?.labels?.foo, 'bar');
+    assert.strictEqual(patchedNS.metadata?.labels?.initialLabel, undefined);
     console.log('Namespace patched with new label.');
 }