Skip to content

Commit 957e260

Browse files
committed
change type GetPodMetricsOptions to MetricsOptions
1 parent 3db5472 commit 957e260

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/metrics.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export interface SingleNodeMetrics extends NodeMetric {
6666
apiVersion: 'metrics.k8s.io/v1beta1';
6767
}
6868

69-
export interface GetPodMetricsOptions {
69+
export interface MetricsOptions {
7070
/**
7171
* restrict the list of returned objects by labels
7272
*/
@@ -80,11 +80,11 @@ export class Metrics {
8080
this.config = config;
8181
}
8282

83-
public async getNodeMetrics(options?: GetPodMetricsOptions): Promise<NodeMetricsList>;
84-
public async getNodeMetrics(node: string, options?: GetPodMetricsOptions): Promise<SingleNodeMetrics>;
83+
public async getNodeMetrics(options?: MetricsOptions): Promise<NodeMetricsList>;
84+
public async getNodeMetrics(node: string, options?: MetricsOptions): Promise<SingleNodeMetrics>;
8585
public async getNodeMetrics(
86-
nodeOrOptions?: string | GetPodMetricsOptions,
87-
options?: GetPodMetricsOptions,
86+
nodeOrOptions?: string | MetricsOptions,
87+
options?: MetricsOptions,
8888
): Promise<NodeMetricsList | SingleNodeMetrics> {
8989
if (typeof nodeOrOptions !== 'string' || nodeOrOptions === '') {
9090
if (nodeOrOptions !== '') {
@@ -98,17 +98,17 @@ export class Metrics {
9898
);
9999
}
100100

101-
public async getPodMetrics(options?: GetPodMetricsOptions): Promise<PodMetricsList>;
102-
public async getPodMetrics(namespace?: string, options?: GetPodMetricsOptions): Promise<PodMetricsList>;
101+
public async getPodMetrics(options?: MetricsOptions): Promise<PodMetricsList>;
102+
public async getPodMetrics(namespace?: string, options?: MetricsOptions): Promise<PodMetricsList>;
103103
public async getPodMetrics(
104104
namespace: string,
105105
name: string,
106-
options?: GetPodMetricsOptions,
106+
options?: MetricsOptions,
107107
): Promise<SinglePodMetrics>;
108108
public async getPodMetrics(
109-
namespaceOrOptions?: string | GetPodMetricsOptions,
110-
nameOrOptions?: string | GetPodMetricsOptions,
111-
options?: GetPodMetricsOptions,
109+
namespaceOrOptions?: string | MetricsOptions,
110+
nameOrOptions?: string | MetricsOptions,
111+
options?: MetricsOptions,
112112
): Promise<SinglePodMetrics | PodMetricsList> {
113113
let path: string;
114114

@@ -136,7 +136,7 @@ export class Metrics {
136136

137137
private async metricsApiRequest<
138138
T extends PodMetricsList | NodeMetricsList | SinglePodMetrics | SingleNodeMetrics,
139-
>(path: string, options?: GetPodMetricsOptions): Promise<T> {
139+
>(path: string, options?: MetricsOptions): Promise<T> {
140140
const cluster = this.config.getCurrentCluster();
141141
if (!cluster) {
142142
throw new Error('No currently active cluster');

0 commit comments

Comments
 (0)