Merge pull request #150 from brendandburns/ut

k8s-ci-robot · web-flow · commit d0774f4a42b5 · 2018-11-12T22:54:15.000-08:00
Improve tests.
diff --git a/package.json b/package.json
@@ -27,6 +27,7 @@
     ],
     "exclude": [
       "src/api.ts",
+      "src/index.ts",
       "src/*_test.ts"
     ],
     "extension": [
diff --git a/src/web-socket-handler.ts b/src/web-socket-handler.ts
@@ -74,10 +74,10 @@ export class WebSocketHandler implements WebSocketInterface {
         return true;
     }
 
-    public 'config': KubeConfig;
-
-    public constructor(config: KubeConfig) {
-        this.config = config;
+    // factory is really just for test injection
+    public constructor(readonly config: KubeConfig,
+                       readonly socketFactory?:
+                         (uri: string, opts: WebSocket.ClientOptions) => WebSocket) {
     }
 
     /**
@@ -109,7 +109,7 @@ export class WebSocketHandler implements WebSocketInterface {
         this.config.applytoHTTPSOptions(opts);
 
         return new Promise((resolve, reject) => {
-            const client = new WebSocket(uri, opts);
+            const client = (this.socketFactory ? this.socketFactory(uri, opts) : new WebSocket(uri, opts));
             let resolved = false;
 
             client.onopen = () => {
diff --git a/src/web-socket-handler_test.ts b/src/web-socket-handler_test.ts
@@ -1,12 +1,52 @@
 import { expect } from 'chai';
+import WebSocket = require('isomorphic-ws');
 import { ReadableStreamBuffer, WritableStreamBuffer } from 'stream-buffers';
 import { anyFunction, capture, instance, mock, reset, verify } from 'ts-mockito';
 
+import { V1Status } from './api';
 import { KubeConfig } from './config';
-import { PortForward } from './portforward';
+import { Cluster, Context, User } from './config_types';
 import { WebSocketHandler, WebSocketInterface } from './web-socket-handler';
 
 describe('WebSocket', () => {
+    it('should throw on unknown code', () => {
+        const osStream = new WritableStreamBuffer();
+        const errStream = new WritableStreamBuffer();
+        const buff = Buffer.alloc(30, 20);
+        const badStream = 10;
+
+        expect(() => WebSocketHandler.handleStandardStreams(badStream, buff, osStream, errStream))
+            .to.throw(`Unknown stream: ${badStream}`);
+    });
+    it('should handle a status to end', () => {
+        const osStream = new WritableStreamBuffer();
+        const errStream = new WritableStreamBuffer();
+
+        const status = new V1Status();
+        status.message = 'Some message';
+        status.reason = 'Some Reason';
+        const data = JSON.stringify(status);
+
+        const buff = Buffer.alloc(data.length);
+        buff.write(data);
+
+        const output = WebSocketHandler.handleStandardStreams(WebSocketHandler.StatusStream, buff, osStream, errStream);
+
+        expect(osStream.size()).to.equal(0);
+        expect(errStream.size()).to.equal(0);
+        /* tslint:disable:no-unused-expression */
+        expect(output).to.not.be.null;
+    });
+    it('should handle empty buffers', () => {
+        const osStream = new WritableStreamBuffer();
+        const errStream = new WritableStreamBuffer();
+        const buff = Buffer.alloc(0, 20);
+
+        WebSocketHandler.handleStandardStreams(WebSocketHandler.StdoutStream, buff, osStream, errStream);
+
+        expect(osStream.size()).to.equal(0);
+        expect(errStream.size()).to.equal(0);
+    });
     it('should handle output streams', () => {
         const osStream = new WritableStreamBuffer();
         const errStream = new WritableStreamBuffer();
@@ -37,4 +77,202 @@ describe('WebSocket', () => {
             expect(outputBuffer2[i]).to.equal(fill2);
         }
     });
+    it('should throw on a config with no cluster', () => {
+        const config = new KubeConfig();
+        const handler = new WebSocketHandler(config);
+        expect(() => handler.connect('/some/path', null, null)).to.throw('No cluster is defined.');
+    });
+    it('should error on bad connection', async () => {
+        const kc = new KubeConfig();
+        const server = 'foo.company.nonexistent';
+        kc.clusters = [
+            {
+                name: 'cluster',
+                server,
+            } as Cluster,
+        ] as Cluster[];
+        kc.contexts = [
+            {
+                cluster: 'cluster',
+                user: 'user',
+            } as Context,
+        ] as Context[];
+        kc.users = [
+            {
+                name: 'user',
+            } as User,
+        ];
+
+        const mockWs = {} as WebSocket;
+        let uriOut = '';
+
+        const handler = new WebSocketHandler(kc, (uri: string, opts: WebSocket.ClientOptions): WebSocket => {
+            uriOut = uri;
+            return mockWs as WebSocket;
+        });
+        const path = '/some/path';
+
+        const promise = handler.connect(path, null, null);
+
+        mockWs.onerror({
+            error: 'some error',
+            message: 'some message',
+            type: 'type',
+            target: mockWs,
+        });
+
+        let rejected = false;
+        try {
+            const val = await promise;
+        } catch (err) {
+            rejected = true;
+        }
+        expect(rejected).to.equal(true);
+    });
+    it('should connect properly', async () => {
+        const kc = new KubeConfig();
+        const host = 'foo.company.com';
+        const server = `https://${host}`;
+        kc.clusters = [
+            {
+                name: 'cluster',
+                server,
+            } as Cluster,
+        ] as Cluster[];
+        kc.contexts = [
+            {
+                cluster: 'cluster',
+                user: 'user',
+            } as Context,
+        ] as Context[];
+        kc.users = [
+            {
+                name: 'user',
+            } as User,
+        ];
+
+        const mockWs = {} as WebSocket;
+        let uriOut = '';
+
+        const handler = new WebSocketHandler(kc, (uri: string, opts: WebSocket.ClientOptions): WebSocket => {
+            uriOut = uri;
+            return mockWs as WebSocket;
+        });
+        const path = '/some/path';
+
+        const promise = handler.connect(path, null, null);
+
+        expect(uriOut).to.equal(`wss://${host}${path}`);
+
+        const event = {
+            target: mockWs,
+        };
+        mockWs.onopen(event);
+        const errEvt = {
+            error: {},
+            message: 'some message',
+            type: 'some type',
+            target: mockWs,
+        };
+        mockWs.onmessage({
+            data: 'string data',
+            type: 'type',
+            target: mockWs,
+        });
+        const buff = Buffer.alloc(10, 100);
+        mockWs.onmessage({
+            data: buff,
+            type: 'type',
+            target: mockWs,
+        });
+        mockWs.onerror(errEvt);
+        await promise;
+    });
+    it('should connect properly with handlers', async () => {
+        const kc = new KubeConfig();
+        const host = 'foo.company.com';
+        const server = `https://${host}`;
+        kc.clusters = [
+            {
+                name: 'cluster',
+                server,
+            } as Cluster,
+        ] as Cluster[];
+        kc.contexts = [
+            {
+                cluster: 'cluster',
+                user: 'user',
+            } as Context,
+        ] as Context[];
+        kc.users = [
+            {
+                name: 'user',
+            } as User,
+        ];
+
+        let closeCount = 0;
+        const mockWs = {
+            close: () => { closeCount++; },
+        } as WebSocket;
+        let uriOut = '';
+
+        const handler = new WebSocketHandler(kc, (uri: string, opts: WebSocket.ClientOptions): WebSocket => {
+            uriOut = uri;
+            return mockWs as WebSocket;
+        });
+        const path = '/some/path';
+
+        let textReceived = '';
+        const textHandler = (text: string): boolean => {
+            textReceived = text;
+            return false;
+        };
+
+        let dataReceived: Buffer = Buffer.alloc(0, 0);
+        let streamNumber = -1;
+        const binaryHandler = (stream: number, data: Buffer): boolean => {
+            streamNumber = stream;
+            dataReceived = data;
+            return false;
+        };
+
+        const promise = handler.connect(path, textHandler, binaryHandler);
+
+        expect(uriOut).to.equal(`wss://${host}${path}`);
+
+        const event = {
+            target: mockWs,
+        };
+        mockWs.onopen(event);
+        const errEvt = {
+            error: {},
+            message: 'some message',
+            type: 'some type',
+            target: mockWs,
+        };
+        mockWs.onmessage({
+            data: 'string data',
+            type: 'type',
+            target: mockWs,
+        });
+        const fill = 100;
+        const size = 10;
+        const buff = Buffer.alloc(size, fill);
+        mockWs.onmessage({
+            data: buff,
+            type: 'type',
+            target: mockWs,
+        });
+        mockWs.onerror(errEvt);
+        await promise;
+
+        expect(closeCount).to.equal(2);
+        expect(textReceived).to.equal('string data');
+
+        expect(streamNumber).to.equal(fill);
+        expect(dataReceived.length).to.equal(size - 1);
+        for (const datum of dataReceived) {
+            expect(datum).to.equal(fill);
+        }
+    });
 });
