chore: address reviewer feedback 3

Author: Tanmayshi

src/yaml.ts

@@ -9,7 +9,7 @@ import { ObjectSerializer } from './serializer.js';
  * @param opts - Optional YAML parse options.
  * @returns The deserialized Kubernetes object.
  */
-export function loadYaml<T>(data: string, opts?: yaml.ParseOptions): T {
+export function loadYaml<T>(data: string, opts?: yaml.ParseOptions & yaml.DocumentOptions): T {
     const yml = yaml.parse(data, { version: '1.1', ...opts }) as any as KubernetesObject;
     if (!yml) {
         throw new Error('Failed to load yaml');
@@ -24,7 +24,10 @@ export function loadYaml<T>(data: string, opts?: yaml.ParseOptions): T {
  * @param opts - Optional YAML parse options.
  * @returns An array of deserialized Kubernetes objects.
  */
-export function loadAllYaml(data: string, opts?: yaml.ParseOptions): KubernetesObject[] {
+export function loadAllYaml(
+    data: string,
+    opts?: yaml.ParseOptions & yaml.DocumentOptions & yaml.SchemaOptions,
+): any[] {
     const ymls = yaml.parseAllDocuments(data, { version: '1.1', ...opts });
     return ymls.map((doc) => {
         const obj = doc.toJSON() as KubernetesObject;

src/yaml_test.ts

@@ -1,6 +1,6 @@
 import { describe, it } from 'node:test';
 import { deepEqual, deepStrictEqual, strictEqual } from 'node:assert';
-import { V1CustomResourceDefinition, V1Namespace, V1Pod } from './api.js';
+import { V1CustomResourceDefinition, V1Namespace } from './api.js';
 import { dumpYaml, loadAllYaml, loadYaml } from './yaml.js';
 
 describe('yaml', () => {
@@ -84,27 +84,22 @@ spec:
         const objects = loadAllYaml(yaml);
 
         strictEqual(objects.length, 3);
-        // Assert specific types for each object
-        const ns = objects[0] as V1Namespace;
-        const pod = objects[1] as V1Pod;
-        const crd = objects[2] as V1CustomResourceDefinition;
-
-        strictEqual(ns.kind, 'Namespace');
-        strictEqual(pod.kind, 'Pod');
-        strictEqual(ns.metadata!.name, 'some-namespace');
-        strictEqual(pod.metadata!.name, 'some-pod');
-        strictEqual(pod.metadata!.namespace, 'some-ns');
-
-        strictEqual(crd.apiVersion, 'apiextensions.k8s.io/v1');
-        strictEqual(crd.kind, 'CustomResourceDefinition');
-        strictEqual(crd.metadata!.name, 'my-crd.example.com');
+        strictEqual(objects[0].kind, 'Namespace');
+        strictEqual(objects[1].kind, 'Pod');
+        strictEqual(objects[0].metadata.name, 'some-namespace');
+        strictEqual(objects[1].metadata.name, 'some-pod');
+        strictEqual(objects[1].metadata.namespace, 'some-ns');
+        strictEqual(objects[2].apiVersion, 'apiextensions.k8s.io/v1');
+        strictEqual(objects[2].kind, 'CustomResourceDefinition');
+        strictEqual(objects[2].metadata!.name, 'my-crd.example.com');
         strictEqual(
-            crd.spec.versions[0]!.schema!.openAPIV3Schema!.properties!['foobar'].x_kubernetes_int_or_string,
+            objects[2].spec.versions[0]!.schema!.openAPIV3Schema!.properties!['foobar']
+                .x_kubernetes_int_or_string,
             true,
         );
         strictEqual(
-            crd.spec.versions[0]!.schema!.openAPIV3Schema!.properties!['foobar'][
-                'x-kubernetes-int-or-string' // This access is still on the parsed object before type mapping, hence `undefined` is correct
+            objects[2].spec.versions[0]!.schema!.openAPIV3Schema!.properties!['foobar'][
+                'x-kubernetes-int-or-string'
             ],
             undefined,
         );