use typescript overloading to retain old log signature

Author: Legion2

src/log.ts

@@ -56,8 +56,32 @@ export class Log {
         podName: string,
         containerName: string,
         stream: Writable,
-        options: LogOptions = {},
+        options?: LogOptions,
+    ): Promise<request.Request>;
+    /** @deprecated done callback is deprecated */
+    public async log(
+        namespace: string,
+        podName: string,
+        containerName: string,
+        stream: Writable,
+        done: (err: any) => void,
+        options?: LogOptions,
+    ): Promise<request.Request>;
+    public async log(
+        namespace: string,
+        podName: string,
+        containerName: string,
+        stream: Writable,
+        doneOrOptions?: ((err: any) => void) | LogOptions,
+        options?: LogOptions,
     ): Promise<request.Request> {
+        let done: (err: any) => void = () => undefined;
+        if (typeof doneOrOptions === 'function') {
+            done = doneOrOptions;
+        } else {
+            options = doneOrOptions;
+        }
+
         const path = `/api/v1/namespaces/${namespace}/pods/${podName}/log`;
 
         const cluster = this.config.getCurrentCluster();
@@ -80,9 +104,13 @@ export class Log {
             const req = request(requestOptions, (error, response, body) => {
                 if (error) {
                     reject(error);
+                    done(error);
                 } else if (response.statusCode !== 200) {
-                    body = ObjectSerializer.deserialize(JSON.parse(body), 'V1Status');
-                    reject(new HttpError(response, body, response.statusCode));
+                    const deserializedBody = ObjectSerializer.deserialize(JSON.parse(body), 'V1Status');
+                    reject(new HttpError(response, deserializedBody, response.statusCode));
+                    done(body);
+                } else {
+                    done(null);
                 }
             }).on('response', (response) => {
                 if (response.statusCode === 200) {