Merge pull request #1810 from 0x5457/fix-exec-auth-error

fix: if spawnSync has an error should throw it

Author: k8s-ci-robot

src/exec_auth.ts

@@ -100,6 +100,9 @@ export class ExecAuth implements Authenticator {
             opts = { ...opts, env };
         }
         const result = this.execFn(exec.command, exec.args, opts);
+        if (result.error) {
+            throw result.error;
+        }
         if (result.status === 0) {
             const obj = JSON.parse(result.stdout.toString('utf8')) as Credential;
             this.tokenCache[user.name] = obj;

src/exec_auth_test.ts

@@ -192,6 +192,39 @@ describe('ExecAuth', () => {
         expect(opts.headers.Authorization).to.be.undefined;
     });
 
+    it('should throw on spawnSync errors', () => {
+        // TODO: fix this test for Windows
+        if (process.platform === 'win32') {
+            return;
+        }
+        const auth = new ExecAuth();
+        (auth as any).execFn = (
+            command: string,
+            args: string[],
+            opts: child_process.SpawnOptions,
+        ): child_process.SpawnSyncReturns<Buffer> => {
+            return {
+                error: new Error('Error: spawnSync /path/to/bin ENOENT'),
+            } as child_process.SpawnSyncReturns<Buffer>;
+        };
+
+        const user = {
+            name: 'user',
+            authProvider: {
+                config: {
+                    exec: {
+                        command: '/path/to/bin',
+                    },
+                },
+            },
+        };
+        const opts = {} as https.RequestOptions;
+        opts.headers = {} as OutgoingHttpHeaders;
+
+        const promise = auth.applyAuthentication(user, opts);
+        return expect(promise).to.eventually.be.rejected.and.not.instanceOf(TypeError);
+    });
+
     it('should throw on exec errors', () => {
         // TODO: fix this test for Windows
         if (process.platform === 'win32') {