Skip to content

Commit ebb49d0

Browse files
committed
Use safe_load and safe_dump for all yaml calls
1 parent 5c242ea commit ebb49d0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

config/kube_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ def get_with_name(self, name, safe=False):
493493
def _get_kube_config_loader_for_yaml_file(filename, **kwargs):
494494
with open(filename) as f:
495495
return KubeConfigLoader(
496-
config_dict=yaml.load(f),
496+
config_dict=yaml.safe_load(f),
497497
config_base_path=os.path.abspath(os.path.dirname(filename)),
498498
**kwargs)
499499

config/kube_config_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -896,14 +896,14 @@ def test_ssl_with_relative_ssl_files(self):
896896
def test_load_kube_config(self):
897897
expected = FakeConfig(host=TEST_HOST,
898898
token=BEARER_TOKEN_FORMAT % TEST_DATA_BASE64)
899-
config_file = self._create_temp_file(yaml.dump(self.TEST_KUBE_CONFIG))
899+
config_file = self._create_temp_file(yaml.safe_dump(self.TEST_KUBE_CONFIG))
900900
actual = FakeConfig()
901901
load_kube_config(config_file=config_file, context="simple_token",
902902
client_configuration=actual)
903903
self.assertEqual(expected, actual)
904904

905905
def test_list_kube_config_contexts(self):
906-
config_file = self._create_temp_file(yaml.dump(self.TEST_KUBE_CONFIG))
906+
config_file = self._create_temp_file(yaml.safe_dump(self.TEST_KUBE_CONFIG))
907907
contexts, active_context = list_kube_config_contexts(
908908
config_file=config_file)
909909
self.assertDictEqual(self.TEST_KUBE_CONFIG['contexts'][0],
@@ -916,7 +916,7 @@ def test_list_kube_config_contexts(self):
916916
contexts)
917917

918918
def test_new_client_from_config(self):
919-
config_file = self._create_temp_file(yaml.dump(self.TEST_KUBE_CONFIG))
919+
config_file = self._create_temp_file(yaml.safe_dump(self.TEST_KUBE_CONFIG))
920920
client = new_client_from_config(
921921
config_file=config_file, context="simple_token")
922922
self.assertEqual(TEST_HOST, client.configuration.host)

0 commit comments

Comments
 (0)