Remove TODO comments

Signed-off-by: Prasad Ghangal <[email protected]>

Author: PrasadG193

cmd/hostpathplugin/main.go

@@ -57,7 +57,6 @@ func main() {
 
 	flag.BoolVar(&cfg.EnableVolumeExpansion, "enable-volume-expansion", true, "Enables volume expansion feature.")
 	flag.BoolVar(&cfg.EnableControllerModifyVolume, "enable-controller-modify-volume", false, "Enables Controller modify volume feature.")
-	// TODO: Remove this feature flag and enable SnapshotMetadata service by default once external-snapshot-metadata alpha is released.
 	flag.BoolVar(&cfg.EnableSnapshotMetadata, "enable-snapshot-metadata", false, "Enables Snapshot Metadata service.")
 	snapshotMetadataBlockType := flag.String("snapshot-metadata-block-type", "FIXED_LENGTH", "Expected Snapshot Metadata block type in response. Allowed valid types are FIXED_LENGTH or VARIABLE_LENGTH. If not specified, FIXED_LENGTH is used by default.")
 	flag.Var(&cfg.AcceptedMutableParameterNames, "accepted-mutable-parameter-names", "Comma separated list of parameter names that can be modified on a persistent volume. This is only used when enable-controller-modify-volume is true. If unset, all parameters are mutable.")

pkg/hostpath/hostpath.go

@@ -132,8 +132,6 @@ func NewHostPathDriver(cfg Config) (*hostPath, error) {
 
 func (hp *hostPath) Run() error {
 	s := NewNonBlockingGRPCServer()
-	// hp itself implements ControllerServer, NodeServer, IdentityServer, and SnapshotMetadataServer.
-	// TODO: Enable SnapshotMetadata service by default once external-snapshot-metadata alpha is released.
 	var sms csi.SnapshotMetadataServer
 	if hp.config.EnableSnapshotMetadata {
 		sms = hp

pkg/hostpath/snapshotmetadata.go

@@ -26,6 +26,9 @@ import (
 	"k8s.io/klog/v2"
 )
 
+// NOTE: This implementation of SnapshotMetadata service is used for demo and CI testing purpose only.
+// This should not be used in production or as an example about how to write a real driver.
+
 func (hp *hostPath) getAllocatedBlockMetadata(ctx context.Context, filePath string, startingOffset, blockSize int64, maxResult int32, allocBlocksChan chan<- []*csi.BlockMetadata) error {
 	klog.V(4).Infof("finding allocated blocks in the file: %s", filePath)
 	defer close(allocBlocksChan)