test: use copyloopvar golint rule

andyzhangx · andyzhangx · commit 86992b36ce2c · 2025-04-02T09:41:46.000Z
fix golint
diff --git a/.github/workflows/static.yaml b/.github/workflows/static.yaml
@@ -16,7 +16,7 @@ jobs:
               uses: golangci/golangci-lint-action@v6
               with:
                   version: v1.64
-                  args: -E=gofmt,unused,ineffassign,revive,misspell,exportloopref,asciicheck,bodyclose,contextcheck --timeout=30m0s
+                  args: -E=gofmt,unused,ineffassign,revive,misspell,copyloopvar,asciicheck,bodyclose,contextcheck --timeout=30m0s
     verify-helm:
         name: Verify Helm
         runs-on: ubuntu-latest
diff --git a/pkg/nfs/controllerserver_test.go b/pkg/nfs/controllerserver_test.go
@@ -218,7 +218,6 @@ func TestCreateVolume(t *testing.T) {
 	}
 
 	for _, test := range cases {
-		test := test //pin
 		t.Run(test.name, func(t *testing.T) {
 			// Setup
 			cs := initTestController(t)
@@ -300,7 +299,6 @@ func TestDeleteVolume(t *testing.T) {
 	}
 
 	for _, test := range cases {
-		test := test //pin
 		if runtime.GOOS == "windows" && !test.testOnWindows {
 			continue
 		}
@@ -386,7 +384,6 @@ func TestControllerGetCapabilities(t *testing.T) {
 	}
 
 	for _, test := range cases {
-		test := test //pin
 		t.Run(test.desc, func(t *testing.T) {
 			// Setup
 			cs := initTestController(t)

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,6 @@ func TestCreateVolume(t *testing.T) {`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`for _, test := range cases {`
`221`		`- test := test //pin`
`222`	`221`	`t.Run(test.name, func(t *testing.T) {`
`223`	`222`	`// Setup`
`224`	`223`	`cs := initTestController(t)`
`@@ -300,7 +299,6 @@ func TestDeleteVolume(t *testing.T) {`
`300`	`299`	`}`
`301`	`300`
`302`	`301`	`for _, test := range cases {`
`303`		`- test := test //pin`
`304`	`302`	`if runtime.GOOS == "windows" && !test.testOnWindows {`
`305`	`303`	`continue`
`306`	`304`	`}`
`@@ -386,7 +384,6 @@ func TestControllerGetCapabilities(t *testing.T) {`
`386`	`384`	`}`
`387`	`385`
`388`	`386`	`for _, test := range cases {`
`389`		`- test := test //pin`
`390`	`387`	`t.Run(test.desc, func(t *testing.T) {`
`391`	`388`	`// Setup`
`392`	`389`	`cs := initTestController(t)`