Skip to content

baseRepo feature is difficult to use #991

@jabbera

Description

@jabbera

Is your feature request related to a problem?/Why is this needed

The baseRepo feature is difficult to use because the repository tags here:

repository: registry.k8s.io/sig-storage/nfsplugin

include the baseRepo in the line. To redirect all images you now need to write this:

image:
  baseRepo: yourcache.azurecr.io/registry-k8s-io
  nfs: 
    repository: /sig-storage/nfsplugin
  csiProvisioner:
    repository: /sig-storage/csi-provisioner
  csiResizer:
    repository: /sig-storage/csi-resizer
  csiSnapshotter:
    repository: /sig-storage/csi-snapshotter
  livenessProbe:
    repository: /sig-storage/livenessprobe
  nodeDriverRegistrar:
    repository: /sig-storage/csi-node-driver-registrar
  externalSnapshotter:
    repository: /sig-storage/snapshot-controller

because the baseRepo feature only works if the repository starts with a /

{{- if hasPrefix "/" .Values.image.csiProvisioner.repository }}

If the registry was removed from all the repository sections as above

repository: /sig-storage/nfsplugin

the chart would use the base repo by default, then anyone wanting to override it would just need to do something like:

image:
  baseRepo: yourcache.azurecr.io/registry-k8s-io

and omit the setting of each components repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions