Skip to content

Commit 15c72c6

Browse files
authored
Merge pull request #339 from andyzhangx/remove-windows-image-chart
cleanup: remove windows image config in chart
2 parents 9a481b3 + c1a65f8 commit 15c72c6

File tree

7 files changed

+79
-89
lines changed

7 files changed

+79
-89
lines changed

charts/README.md

Lines changed: 59 additions & 65 deletions
Large diffs are not rendered by default.
-84 Bytes
Binary file not shown.

charts/latest/csi-driver-smb/templates/csi-smb-node-windows.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ spec:
3131
volumeMounts:
3232
- mountPath: C:\csi
3333
name: plugin-dir
34-
{{- if hasPrefix "/" .Values.windows.image.livenessProbe.repository }}
35-
image: "{{ .Values.image.baseRepo }}{{ .Values.windows.image.livenessProbe.repository }}:{{ .Values.windows.image.livenessProbe.tag }}"
34+
{{- if hasPrefix "/" .Values.image.livenessProbe.repository }}
35+
image: "{{ .Values.image.baseRepo }}{{ .Values.image.livenessProbe.repository }}:{{ .Values.image.livenessProbe.tag }}"
3636
{{- else }}
37-
image: "{{ .Values.windows.image.livenessProbe.repository }}:{{ .Values.windows.image.livenessProbe.tag }}"
37+
image: "{{ .Values.image.livenessProbe.repository }}:{{ .Values.image.livenessProbe.tag }}"
3838
{{- end }}
3939
args:
4040
- --csi-address=$(CSI_ENDPOINT)
@@ -44,7 +44,7 @@ spec:
4444
env:
4545
- name: CSI_ENDPOINT
4646
value: unix://C:\\csi\\csi.sock
47-
imagePullPolicy: {{ .Values.windows.image.livenessProbe.pullPolicy }}
47+
imagePullPolicy: {{ .Values.image.livenessProbe.pullPolicy }}
4848
resources:
4949
limits:
5050
cpu: 200m
@@ -53,10 +53,10 @@ spec:
5353
cpu: 10m
5454
memory: 20Mi
5555
- name: node-driver-registrar
56-
{{- if hasPrefix "/" .Values.windows.image.nodeDriverRegistrar.repository }}
57-
image: "{{ .Values.image.baseRepo }}{{ .Values.windows.image.nodeDriverRegistrar.repository }}:{{ .Values.windows.image.nodeDriverRegistrar.tag }}"
56+
{{- if hasPrefix "/" .Values.image.nodeDriverRegistrar.repository }}
57+
image: "{{ .Values.image.baseRepo }}{{ .Values.image.nodeDriverRegistrar.repository }}:{{ .Values.image.nodeDriverRegistrar.tag }}"
5858
{{- else }}
59-
image: "{{ .Values.windows.image.nodeDriverRegistrar.repository }}:{{ .Values.windows.image.nodeDriverRegistrar.tag }}"
59+
image: "{{ .Values.image.nodeDriverRegistrar.repository }}:{{ .Values.image.nodeDriverRegistrar.tag }}"
6060
{{- end }}
6161
args:
6262
- --v=2
@@ -78,7 +78,7 @@ spec:
7878
valueFrom:
7979
fieldRef:
8080
fieldPath: spec.nodeName
81-
imagePullPolicy: {{ .Values.windows.image.nodeDriverRegistrar.pullPolicy }}
81+
imagePullPolicy: {{ .Values.image.nodeDriverRegistrar.pullPolicy }}
8282
volumeMounts:
8383
- name: plugin-dir
8484
mountPath: C:\csi

charts/latest/csi-driver-smb/values.yaml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ image:
55
tag: latest
66
pullPolicy: IfNotPresent
77
csiProvisioner:
8-
repository: k8s.gcr.io/sig-storage/csi-provisioner
8+
repository: /oss/kubernetes-csi/csi-provisioner
99
tag: v2.1.0
1010
pullPolicy: IfNotPresent
1111
livenessProbe:
12-
repository: k8s.gcr.io/sig-storage/livenessprobe
12+
repository: /oss/kubernetes-csi/livenessprobe
1313
tag: v2.3.0
1414
pullPolicy: IfNotPresent
1515
nodeDriverRegistrar:
16-
repository: k8s.gcr.io/sig-storage/csi-node-driver-registrar
16+
repository: /oss/kubernetes-csi/csi-node-driver-registrar
1717
tag: v2.3.0
1818
pullPolicy: IfNotPresent
1919

@@ -110,15 +110,6 @@ windows:
110110
enabled: false
111111
dsName: csi-smb-node-win # daemonset name
112112
kubelet: 'C:\var\lib\kubelet'
113-
image:
114-
livenessProbe:
115-
repository: /oss/kubernetes-csi/livenessprobe
116-
tag: v2.3.0
117-
pullPolicy: IfNotPresent
118-
nodeDriverRegistrar:
119-
repository: /oss/kubernetes-csi/csi-node-driver-registrar
120-
tag: v2.3.0
121-
pullPolicy: IfNotPresent
122113
tolerations:
123114
- key: "node.kubernetes.io/os"
124115
operator: "Exists"

deploy/csi-smb-controller.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ spec:
2828
effect: "NoSchedule"
2929
containers:
3030
- name: csi-provisioner
31-
image: k8s.gcr.io/sig-storage/csi-provisioner:v2.1.0
31+
image: mcr.microsoft.com/oss/kubernetes-csi/csi-provisioner:v2.1.0
3232
args:
3333
- "-v=2"
3434
- "--csi-address=$(ADDRESS)"
@@ -47,7 +47,7 @@ spec:
4747
cpu: 10m
4848
memory: 20Mi
4949
- name: liveness-probe
50-
image: k8s.gcr.io/sig-storage/livenessprobe:v2.3.0
50+
image: mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.3.0
5151
args:
5252
- --csi-address=/csi/csi.sock
5353
- --probe-timeout=3s

deploy/csi-smb-node.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
volumeMounts:
3030
- mountPath: /csi
3131
name: socket-dir
32-
image: k8s.gcr.io/sig-storage/livenessprobe:v2.3.0
32+
image: mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.3.0
3333
args:
3434
- --csi-address=/csi/csi.sock
3535
- --probe-timeout=3s
@@ -43,7 +43,7 @@ spec:
4343
cpu: 10m
4444
memory: 20Mi
4545
- name: node-driver-registrar
46-
image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0
46+
image: mcr.microsoft.com/oss/kubernetes-csi/csi-node-driver-registrar:v2.3.0
4747
args:
4848
- --csi-address=$(ADDRESS)
4949
- --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)

test/utils/smb_log.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ kubectl get pods -n${NS} -l${LABEL} \
4949
| awk 'NR>1 {print $1}' \
5050
| xargs -I {} kubectl logs {} --prefix -c${CONTAINER} -n${NS}
5151

52+
echo "print out csi-$DRIVER-node-win events ..."
53+
echo "======================================================================================"
54+
LABEL="app=csi-$DRIVER-node-win"
55+
kubectl describe pods -n${NS} -l${LABEL}
56+
5257
echo "print out csi-$DRIVER-node-win logs ..."
5358
echo "======================================================================================"
5459
LABEL="app=csi-$DRIVER-node-win"

0 commit comments

Comments
 (0)