chore: Upgrade golangci-lint version

- Upgrades golangci-ling to v1.64.5
- Fixes The linter 'exportloopref' is deprecated (since v1.60.2) due to:
  Since Go1.22 (loopvar) this linter is no longer relevant.
  Replaced by copyloopvar.
- Fixes unused-parameter linter warnings
- Fixes redefined builtin cap linter warnings

Signed-off-by: Raymond Etornam <[email protected]>

Author: retornam

.github/workflows/static.yaml

@@ -15,5 +15,5 @@ jobs:
             - name: Run linter
               uses: golangci/golangci-lint-action@v6
               with:
-                  version: v1.60
-                  args: -E=gofmt,unused,ineffassign,revive,misspell,exportloopref,asciicheck,bodyclose,contextcheck,depguard,dogsled,durationcheck,errname,forbidigo -D=staticcheck --timeout=30m0s
+                  version: v1.64.5
+                  args: -E=gofmt,unused,ineffassign,revive,misspell,copyloopvar,asciicheck,bodyclose,contextcheck,depguard,dogsled,durationcheck,errname,forbidigo -D=staticcheck --timeout=30m0s

pkg/csi-common/utils.go

@@ -42,21 +42,21 @@ func NewVolumeCapabilityAccessMode(mode csi.VolumeCapability_AccessMode_Mode) *c
 	return &csi.VolumeCapability_AccessMode{Mode: mode}
 }
 
-func NewControllerServiceCapability(cap csi.ControllerServiceCapability_RPC_Type) *csi.ControllerServiceCapability {
+func NewControllerServiceCapability(capability csi.ControllerServiceCapability_RPC_Type) *csi.ControllerServiceCapability {
 	return &csi.ControllerServiceCapability{
 		Type: &csi.ControllerServiceCapability_Rpc{
 			Rpc: &csi.ControllerServiceCapability_RPC{
-				Type: cap,
+				Type: capability,
 			},
 		},
 	}
 }
 
-func NewNodeServiceCapability(cap csi.NodeServiceCapability_RPC_Type) *csi.NodeServiceCapability {
+func NewNodeServiceCapability(capability csi.NodeServiceCapability_RPC_Type) *csi.NodeServiceCapability {
 	return &csi.NodeServiceCapability{
 		Type: &csi.NodeServiceCapability_Rpc{
 			Rpc: &csi.NodeServiceCapability_RPC{
-				Type: cap,
+				Type: capability,
 			},
 		},
 	}

pkg/smb/controllerserver_test.go

@@ -181,7 +181,6 @@ func TestCreateVolume(t *testing.T) {
 	}
 
 	for _, test := range cases {
-		test := test //pin
 		t.Run(test.name, func(t *testing.T) {
 			if test.skipOnWindows && runtime.GOOS == "windows" {
 				return
@@ -265,7 +264,6 @@ func TestDeleteVolume(t *testing.T) {
 		},
 	}
 	for _, test := range cases {
-		test := test //pin
 		t.Run(test.desc, func(t *testing.T) {
 			// Setup
 			_ = os.MkdirAll(filepath.Join(d.workingMountDir, testCSIVolume), os.ModePerm)
@@ -562,7 +560,6 @@ func TestGetSmbVolFromID(t *testing.T) {
 		},
 	}
 	for _, test := range cases {
-		test := test //pin
 		t.Run(test.desc, func(t *testing.T) {
 			smbVolume, err := getSmbVolFromID(test.volumeID)
 

pkg/smb/smb_common_darwin.go

@@ -26,10 +26,12 @@ import (
 )
 
 func Mount(m *mount.SafeFormatAndMount, source, target, fsType string, options []string, sensitiveMountOptions []string, volumeID string) error {
+	_ = volumeID
 	return m.MountSensitive(source, target, fsType, options, sensitiveMountOptions)
 }
 
 func CleanupSMBMountPoint(m *mount.SafeFormatAndMount, target string, extensiveMountCheck bool, volumeID string) error {
+	_ = volumeID
 	return mount.CleanupMountPoint(target, m, extensiveMountCheck)
 }
 
@@ -38,13 +40,18 @@ func CleanupMountPoint(m *mount.SafeFormatAndMount, target string, extensiveMoun
 }
 
 func preparePublishPath(path string, m *mount.SafeFormatAndMount) error {
+	_ = path
+	_ = m
 	return nil
 }
 
 func prepareStagePath(path string, m *mount.SafeFormatAndMount) error {
+	_ = path
+	_ = m
 	return nil
 }
 
 func Mkdir(m *mount.SafeFormatAndMount, name string, perm os.FileMode) error {
+	_ = m // fixes linting
 	return os.Mkdir(name, perm)
 }