Skip to content

Commit 95a3d72

Browse files
authored
Merge pull request #485 from andyzhangx/fix-runOnMaster
fix: incorrect runOnMaster config
2 parents 6a79d3d + ffd1ff3 commit 95a3d72

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ IMAGE_TAG_LATEST = $(REGISTRY)/$(IMAGENAME):latest
4040
BUILD_DATE ?= $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
4141
LDFLAGS = -X ${PKG}/pkg/smb.driverVersion=${IMAGE_VERSION} -X ${PKG}/pkg/smb.gitCommit=${GIT_COMMIT} -X ${PKG}/pkg/smb.buildDate=${BUILD_DATE}
4242
EXT_LDFLAGS = -s -w -extldflags "-static"
43-
E2E_HELM_OPTIONS ?= --set image.smb.repository=$(REGISTRY)/$(IMAGENAME) --set image.smb.tag=$(IMAGE_VERSION) --set controller.dnsPolicy=ClusterFirstWithHostNet --set linux.dnsPolicy=ClusterFirstWithHostNet
43+
E2E_HELM_OPTIONS ?= --set image.smb.repository=$(REGISTRY)/$(IMAGENAME) --set image.smb.tag=$(IMAGE_VERSION) --set controller.dnsPolicy=ClusterFirstWithHostNet --set linux.dnsPolicy=ClusterFirstWithHostNet --set controller.runOnMaster=true
4444
E2E_HELM_OPTIONS += ${EXTRA_HELM_OPTIONS}
4545
# Generate all combination of all OS, ARCH, and OSVERSIONS for iteration
4646
ALL_OS = linux windows
-6 Bytes
Binary file not shown.

charts/latest/csi-driver-smb/templates/csi-smb-controller.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ spec:
3434
{{- end }}
3535
kubernetes.io/os: linux
3636
{{- if .Values.controller.runOnMaster}}
37-
kubernetes.io/role: master
37+
node-role.kubernetes.io/master: ""
3838
{{- end}}
3939
priorityClassName: system-cluster-critical
4040
{{- with .Values.controller.tolerations }}

test/external-e2e/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ setup_e2e_binaries() {
3030
tar -xvf e2e-tests.tar.gz && rm e2e-tests.tar.gz
3131

3232
# test on alternative driver name
33-
export EXTRA_HELM_OPTIONS=" --set driver.name=$DRIVER.csi.k8s.io --set controller.name=csi-$DRIVER-controller --set linux.dsName=csi-$DRIVER-node --set windows.dsName=csi-$DRIVER-node-win"
33+
export EXTRA_HELM_OPTIONS=" --set driver.name=$DRIVER.csi.k8s.io --set controller.name=csi-$DRIVER-controller --set linux.dsName=csi-$DRIVER-node --set windows.dsName=csi-$DRIVER-node-win --set controller.runOnMaster=true"
3434
sed -i "s/smb.csi.k8s.io/$DRIVER.csi.k8s.io/g" deploy/example/storageclass-smb.yaml
3535
sed -i "s/gid=/uid=/g" deploy/example/storageclass-smb.yaml
3636
make install-smb-provisioner

0 commit comments

Comments
 (0)