Merge pull request #102 from andyzhangx/windows-ut-pipeline

andyzhangx · web-flow · commit cf25556cae29 · 2020-09-06T15:43:35.000+08:00
add Windows unit test pipeline
diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -23,3 +23,8 @@ jobs:
       - name: Build
         run: |
           go build -a -o _output/smbplugin.exe ./pkg/smbplugin
+      - name: Run Windows Unit Tests
+        run: |
+          go test -v -race ./pkg/smb/...
+          go test -v -race ./pkg/csi-common/...
+          go test -v -race ./pkg/mounter/...
diff --git a/pkg/mounter/safe_mounter_windows.go b/pkg/mounter/safe_mounter_windows.go
@@ -65,7 +65,7 @@ func (mounter *CSIProxyMounter) SMBMount(source, target, fsType string, mountOpt
 	}
 
 	if !parentExists {
-		klog.Infof("Parent directory %s does not exists. Creating the directory")
+		klog.Infof("Parent directory %s does not exists. Creating the directory", parentDir)
 		err := mounter.MakeDir(parentDir)
 		if err != nil {
 			return fmt.Errorf("create of parent dir: %s dailed with error: %v", parentDir, err)

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ func (mounter *CSIProxyMounter) SMBMount(source, target, fsType string, mountOpt`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`if !parentExists {`
`68`		`- klog.Infof("Parent directory %s does not exists. Creating the directory")`
	`68`	`+ klog.Infof("Parent directory %s does not exists. Creating the directory", parentDir)`
`69`	`69`	`err := mounter.MakeDir(parentDir)`
`70`	`70`	`if err != nil {`
`71`	`71`	`return fmt.Errorf("create of parent dir: %s dailed with error: %v", parentDir, err)`