Cross-port review comment for library-development branch

Author: laozc

docs/IMPLEMENTATION.md

@@ -135,6 +135,17 @@ can be used to retrieve a volume (`MSFT_Volume`) from a partition (`MSFT_Partiti
 collection, err := part.GetAssociated("MSFT_PartitionToVolume", "MSFT_Volume", "Volume", "Partition")
 ```
 
+### Disable checkptr
+
+COM APIs (like IDispatch.Invoke, Variant, BSTR, IUnknown**, etc.) frequently use:
+* Double pointers (e.g., BSTR*, IUnknown**)
+* Pointers passed as int64 or uintptr
+* In-place modification via reference
+
+These patterns are common and valid in C/C++, but violate Go’s unsafe.Pointer rules when interpreted literally - even if they are functionally correct.
+
+Therefore, you should make sure `-gcflags=all=-d=checkptr=0` when calling `microsoft/wmi`.
+
 <a name="debug-powershell"></a>
 ## Debug with PowerShell
 

pkg/os/disk/api.go

@@ -397,6 +397,7 @@ func (imp DiskAPI) SetDiskState(diskNumber uint32, isOnline bool) error {
 		}
 
 		if isOnline == !isOffline {
+			klog.V(2).Infof("Disk %d is already in the desired state", diskNumber)
 			return nil
 		}
 

pkg/os/filesystem/api_test.go

@@ -71,7 +71,7 @@ var (
 
 	serviceStateCheckInternal = 200 * time.Millisecond
 	serviceStateCheckTimeout  = 30 * time.Second
-	errTimedOut               = errors.New("Timed out")
+	errTimedOut               = errors.New("timed out")
 )
 
 func serviceStartModeToStartType(startMode string) uint32 {

pkg/os/system/api.go

@@ -40,7 +40,7 @@ func IsPathValid(path string) (bool, error) {
 		return false, fmt.Errorf("failed to get path %s attribute: %w", path, err)
 	}
 
-	klog.V(6).Infof("Path %s attribute: %d", path, attrs)
+	klog.V(6).Infof("Path %s attribute: %O", path, attrs)
 	return attrs != windows.INVALID_FILE_ATTRIBUTES, nil
 }