Skip to content

Commit e12aec6

Browse files
authored
Merge pull request #407 from mauriciopoppe/presubmit-bios-error
Replace wmic with PowerShell's Get-CimInstance cmdlet
2 parents a070628 + b2b9f45 commit e12aec6

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

integrationtests/system_test.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
"os/exec"
87
"strings"
98
"testing"
109

@@ -25,13 +24,13 @@ func TestGetBIOSSerialNumber(t *testing.T) {
2524
require.Nil(t, err)
2625
require.NotNil(t, response)
2726

28-
result, err := exec.Command("wmic", "bios", "get", "serialnumber").Output()
29-
require.Nil(t, err)
30-
31-
t.Logf("The serial number is %s", response.SerialNumber)
27+
serialNumber, err := runPowershellCmd(t, fmt.Sprintf(`(Get-CimInstance -ClassName Win32_BIOS).SerialNumber`))
28+
if err != nil {
29+
t.Fatalf("command to get serial number failed: %v", err)
30+
}
31+
t.Logf("The serial number is %s", serialNumber)
3232

33-
resultString := string(result)
34-
require.True(t, strings.Contains(resultString, response.SerialNumber))
33+
require.True(t, strings.Contains(serialNumber, response.SerialNumber))
3534
})
3635
}
3736

@@ -57,7 +56,7 @@ func TestServiceCommands(t *testing.T) {
5756
ServiceName))
5857
require.NoError(t, err)
5958

60-
var serviceInfo = struct {
59+
serviceInfo := struct {
6160
DisplayName string `json:"DisplayName"`
6261
Status uint32 `json:"Status"`
6362
StartType uint32 `json:"StartType"`
@@ -96,7 +95,6 @@ func TestServiceCommands(t *testing.T) {
9695
assert.NotNil(t, stopResp)
9796
assertServiceStopped(t, ServiceName)
9897
})
99-
10098
}
10199

102100
func assertServiceStarted(t *testing.T, serviceName string) {

0 commit comments

Comments
 (0)