Skip to content

fix: Ensure IsSymlink works on Windows mounted folder #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix: Ensure IsSymlink works on Windows mounted folder #393

merged 1 commit into from
Jul 11, 2025
+22 −16

Conversation

@laozc
Copy link
Member

@laozc laozc commented Jun 17, 2025 •
edited
Loading

What type of PR is this?
/kind fix

What this PR does / why we need it:
Use utils.IsMountedFolder to check whether the target is a mounted folder in IsSymlink to
ensure the result is correct regardless of Go version.
This also allows csi-proxy to work with Go >= 1.23.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from carlory and gnufied June 17, 2025 11:09
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch 2 times, most recently from 23723f2 to 4dd7e4a Compare June 20, 2025 13:47
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch 5 times, most recently from 05c5b04 to 2b82dea Compare June 21, 2025 07:54
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch from 2b82dea to 027d223 Compare June 27, 2025 01:06
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 27, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch from 027d223 to 6c18f77 Compare July 3, 2025 00:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
andyzhangx
andyzhangx reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch from 6c18f77 to a63a4ec Compare July 3, 2025 03:14
@laozc laozc changed the title Move WMI related functions to cim package cleanup: Move WMI related functions to cim package Jul 3, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch from a63a4ec to 28b7a83 Compare July 3, 2025 04:07
andyzhangx
andyzhangx approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2025
@laozc laozc closed this Jul 10, 2025
@laozc laozc reopened this Jul 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2025
@laozc laozc changed the title cleanup: Move WMI related functions to cim package fix: Ensure IsSymlink works on Windows mount point Jul 10, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch from 28b7a83 to 8bb3fbb Compare July 10, 2025 10:55
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2025
@laozc laozc force-pushed the wmi-process-smb-api branch from 8bb3fbb to 3c06f01 Compare July 11, 2025 02:53
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2025
@laozc laozc mentioned this pull request Jul 11, 2025
Merged
@laozc laozc changed the title fix: Ensure IsSymlink works on Windows mount point fix: Ensure IsSymlink works on Windows mounted folder Jul 11, 2025
andyzhangx
andyzhangx approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, laozc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9755e88 into kubernetes-csi:master Jul 11, 2025
7 of 8 checks passed
@laozc laozc mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@carlory carlory Awaiting requested review from carlory

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@andyzhangx andyzhangx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laozc @k8s-ci-robot @andyzhangx