Update to the new libraries

- csi-lib-utils requires context in few calls
- new feature gate franework checks that feature gates are not set in
  parallel tests.

Author: jsafrane

cmd/csi-provisioner/csi-provisioner.go

@@ -52,7 +52,7 @@ import (
 	_ "k8s.io/component-base/metrics/prometheus/clientgo/leaderelection" // register leader election in the default legacy registry
 	_ "k8s.io/component-base/metrics/prometheus/workqueue"               // register work queues in the default legacy registry
 	csitrans "k8s.io/csi-translation-lib"
-	"k8s.io/klog/v2"
+	klog "k8s.io/klog/v2"
 	"sigs.k8s.io/sig-storage-lib-external-provisioner/v9/controller"
 	libmetrics "sigs.k8s.io/sig-storage-lib-external-provisioner/v9/controller/metrics"
 
@@ -210,13 +210,13 @@ func main() {
 		metrics.WithSubsystem(metrics.SubsystemSidecar),
 	)
 
-	grpcClient, err := ctrl.Connect(*csiEndpoint, metricsManager)
+	grpcClient, err := ctrl.Connect(ctx, *csiEndpoint, metricsManager)
 	if err != nil {
 		klog.Error(err.Error())
 		os.Exit(1)
 	}
 
-	err = ctrl.Probe(grpcClient, *operationTimeout)
+	err = ctrl.Probe(ctx, grpcClient, *operationTimeout)
 	if err != nil {
 		klog.Error(err.Error())
 		os.Exit(1)
@@ -244,15 +244,15 @@ func main() {
 			// Will be provided via default gatherer.
 			metrics.WithProcessStartTime(false),
 			metrics.WithMigration())
-		migratedGrpcClient, err := ctrl.Connect(*csiEndpoint, metricsManager)
+		migratedGrpcClient, err := ctrl.Connect(ctx, *csiEndpoint, metricsManager)
 		if err != nil {
 			klog.Error(err.Error())
 			os.Exit(1)
 		}
 		grpcClient.Close()
 		grpcClient = migratedGrpcClient
 
-		err = ctrl.Probe(grpcClient, *operationTimeout)
+		err = ctrl.Probe(ctx, grpcClient, *operationTimeout)
 		if err != nil {
 			klog.Error(err.Error())
 			os.Exit(1)

pkg/controller/controller.go

@@ -50,7 +50,7 @@ import (
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/tools/record"
 	"k8s.io/client-go/util/workqueue"
-	"k8s.io/klog/v2"
+	klog "k8s.io/klog/v2"
 	"sigs.k8s.io/sig-storage-lib-external-provisioner/v9/controller"
 	"sigs.k8s.io/sig-storage-lib-external-provisioner/v9/util"
 
@@ -288,12 +288,12 @@ var (
 // identify string will be added in PV annotations under this key.
 var provisionerIDKey = "storage.kubernetes.io/csiProvisionerIdentity"
 
-func Connect(address string, metricsManager metrics.CSIMetricsManager) (*grpc.ClientConn, error) {
-	return connection.Connect(address, metricsManager, connection.OnConnectionLoss(connection.ExitOnConnectionLoss()))
+func Connect(ctx context.Context, address string, metricsManager metrics.CSIMetricsManager) (*grpc.ClientConn, error) {
+	return connection.Connect(ctx, address, metricsManager, connection.OnConnectionLoss(connection.ExitOnConnectionLoss()))
 }
 
-func Probe(conn *grpc.ClientConn, singleCallTimeout time.Duration) error {
-	return rpc.ProbeForever(conn, singleCallTimeout)
+func Probe(ctx context.Context, conn *grpc.ClientConn, singleCallTimeout time.Duration) error {
+	return rpc.ProbeForever(ctx, conn, singleCallTimeout)
 }
 
 func GetDriverName(conn *grpc.ClientConn, timeout time.Duration) (string, error) {

pkg/controller/controller_test.go

@@ -46,7 +46,7 @@ import (
 	"k8s.io/component-base/featuregate"
 	utilfeaturetesting "k8s.io/component-base/featuregate/testing"
 	csitrans "k8s.io/csi-translation-lib"
-	"k8s.io/klog/v2"
+	klog "k8s.io/klog/v2"
 	"sigs.k8s.io/sig-storage-lib-external-provisioner/v9/controller"
 
 	"github.com/kubernetes-csi/csi-lib-utils/connection"
@@ -89,7 +89,8 @@ type csiConnection struct {
 
 func New(address string) (csiConnection, error) {
 	metricsManager := metrics.NewCSIMetricsManager("fake.csi.driver.io" /* driverName */)
-	conn, err := connection.Connect(address, metricsManager)
+	ctx := context.Background()
+	conn, err := connection.Connect(ctx, address, metricsManager)
 	if err != nil {
 		return csiConnection{}, err
 	}
@@ -6479,10 +6480,6 @@ func TestProvisionFromPVC(t *testing.T) {
 	for k, tc := range testcases {
 		tc := tc
 		t.Run(k, func(t *testing.T) {
-			// TODO: https://github.com/kubernetes-csi/external-provisioner/issues/833
-			if !tc.xnsEnabled {
-				t.Parallel()
-			}
 			var clientSet *fakeclientset.Clientset
 
 			// Phase: setup mock server