Skip to content

Commit 1368835

Browse files
authored
Merge pull request #475 from AndrewSirenko/leader-metrics
Add leader election, work-queue, process, and Go runtime metrics
2 parents 762c866 + ac11417 commit 1368835

File tree

8 files changed

+242
-11
lines changed

8 files changed

+242
-11
lines changed

cmd/csi-resizer/main.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ import (
5353
"k8s.io/component-base/logs"
5454
logsapi "k8s.io/component-base/logs/api/v1"
5555
_ "k8s.io/component-base/logs/json/register"
56+
"k8s.io/component-base/metrics/legacyregistry"
57+
_ "k8s.io/component-base/metrics/prometheus/clientgo/leaderelection" // register leader election in the default legacy registry
58+
_ "k8s.io/component-base/metrics/prometheus/workqueue" // register work queues in the default legacy registry
5659
)
5760

5861
var (
@@ -177,6 +180,10 @@ func main() {
177180
csiClient = migratedCsiClient
178181
}
179182

183+
// Add default legacy registry so that metrics manager serves Go runtime and process metrics.
184+
// Also registers the `k8s.io/component-base/` work queue and leader election metrics we anonymously import.
185+
metricsManager.WithAdditionalRegistry(legacyregistry.DefaultGatherer)
186+
180187
csiResizer, err := resizer.NewResizerFromClient(
181188
csiClient,
182189
*timeout,

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ require (
66
github.com/container-storage-interface/spec v1.11.0
77
github.com/google/go-cmp v0.6.0
88
github.com/google/gofuzz v1.2.0 // indirect
9-
github.com/kubernetes-csi/csi-lib-utils v0.20.0
9+
github.com/kubernetes-csi/csi-lib-utils v0.21.0
1010
golang.org/x/oauth2 v0.25.0 // indirect
1111
golang.org/x/term v0.28.0 // indirect
1212
google.golang.org/grpc v1.69.2

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
6060
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
6161
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
6262
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
63-
github.com/kubernetes-csi/csi-lib-utils v0.20.0 h1:JTvHRJugn+cByMnIU4nCnqPqOOUhuPzhlLqRvenwjDA=
64-
github.com/kubernetes-csi/csi-lib-utils v0.20.0/go.mod h1:3b/HFVURW11oxV/gUAKyhhkvFpxXO/zRdvh1wdEfCZY=
63+
github.com/kubernetes-csi/csi-lib-utils v0.21.0 h1:dUN/iIgXLucAxyML2iPyhniIlACQumIeAJmIzsMBddc=
64+
github.com/kubernetes-csi/csi-lib-utils v0.21.0/go.mod h1:ZCVRTYuup+bwX9tOeE5Q3LDw64QvltSwMUQ3M3g2T+Q=
6565
github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
6666
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
6767
github.com/mailru/easyjson v0.9.0 h1:PrnmzHw7262yW8sTBwxi1PdJA3Iw/EKBa8psRf7d9a4=

vendor/github.com/kubernetes-csi/csi-lib-utils/metrics/metrics.go

Lines changed: 19 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/kubernetes-csi/csi-lib-utils/protosanitizer/protosanitizer.go

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/component-base/metrics/prometheus/clientgo/leaderelection/metrics.go

Lines changed: 68 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/component-base/metrics/prometheus/workqueue/metrics.go

Lines changed: 137 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/modules.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ github.com/klauspost/compress/internal/cpuinfo
8787
github.com/klauspost/compress/internal/snapref
8888
github.com/klauspost/compress/zstd
8989
github.com/klauspost/compress/zstd/internal/xxhash
90-
# github.com/kubernetes-csi/csi-lib-utils v0.20.0
90+
# github.com/kubernetes-csi/csi-lib-utils v0.21.0
9191
## explicit; go 1.23.1
9292
github.com/kubernetes-csi/csi-lib-utils/accessmodes
9393
github.com/kubernetes-csi/csi-lib-utils/connection
@@ -784,7 +784,9 @@ k8s.io/component-base/logs/json/register
784784
k8s.io/component-base/logs/klogflags
785785
k8s.io/component-base/metrics
786786
k8s.io/component-base/metrics/legacyregistry
787+
k8s.io/component-base/metrics/prometheus/clientgo/leaderelection
787788
k8s.io/component-base/metrics/prometheus/feature
789+
k8s.io/component-base/metrics/prometheus/workqueue
788790
k8s.io/component-base/metrics/prometheusextension
789791
k8s.io/component-base/version
790792
# k8s.io/csi-translation-lib v0.32.0 => k8s.io/csi-translation-lib v0.32.0

0 commit comments

Comments
 (0)