Skip to content

Commit 6c07fa0

Browse files
authored
Merge pull request #844 from mowangdk/cleanup/adopt_kubernetes_recommand_labels
chore: Adopt kubernetes recommand label
2 parents 215f12f + f83e81a commit 6c07fa0

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

deploy/kubernetes/csi-snapshotter/setup-csi-snapshotter.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ apiVersion: v1
4545
metadata:
4646
name: csi-snapshotter
4747
labels:
48-
app: csi-snapshotter
48+
app.kubernetes.io/name: csi-snapshotter
4949
spec:
5050
selector:
51-
app: csi-snapshotter
51+
app.kubernetes.io/name: csi-snapshotter
5252
ports:
5353
- name: dummy
5454
port: 12345
@@ -63,11 +63,11 @@ spec:
6363
replicas: 1
6464
selector:
6565
matchLabels:
66-
app: csi-snapshotter
66+
app.kubernetes.io/name: csi-snapshotter
6767
template:
6868
metadata:
6969
labels:
70-
app: csi-snapshotter
70+
app.kubernetes.io/name: csi-snapshotter
7171
spec:
7272
serviceAccountName: csi-snapshotter
7373
containers:

deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ spec:
1515
replicas: 2
1616
selector:
1717
matchLabels:
18-
app: snapshot-controller
18+
app.kubernetes.io/name: snapshot-controller
1919
# the snapshot controller won't be marked as ready if the v1 CRDs are unavailable
2020
# in #504 the snapshot-controller will exit after around 7.5 seconds if it
2121
# can't find the v1 CRDs so this value should be greater than that
@@ -28,7 +28,7 @@ spec:
2828
template:
2929
metadata:
3030
labels:
31-
app: snapshot-controller
31+
app.kubernetes.io/name: snapshot-controller
3232
spec:
3333
serviceAccountName: snapshot-controller
3434
containers:

deploy/kubernetes/webhook-example/webhook.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ metadata:
55
name: snapshot-validation-deployment
66
namespace: default # NOTE: change the namespace
77
labels:
8-
app: snapshot-validation
8+
app.kubernetes.io/name: snapshot-validation
99
spec:
1010
replicas: 3
1111
selector:
1212
matchLabels:
13-
app: snapshot-validation
13+
app.kubernetes.io/name: snapshot-validation
1414
template:
1515
metadata:
1616
labels:
17-
app: snapshot-validation
17+
app.kubernetes.io/name: snapshot-validation
1818
spec:
1919
serviceAccountName: snapshot-webhook
2020
containers:
@@ -40,7 +40,7 @@ metadata:
4040
namespace: default # NOTE: change the namespace
4141
spec:
4242
selector:
43-
app: snapshot-validation
43+
app.kubernetes.io/name: snapshot-validation
4444
ports:
4545
- protocol: TCP
4646
port: 443 # Change if needed

0 commit comments

Comments
 (0)