sidecar: Get credentials from annotation for snapshots

When a snapshotcontent is created as a result of a volumegroupsnapshot
the status for it is updated by calling the ListSnapshots RPC. Some COs
require the credentials to be present in order to serve this RPC.

The current code tries to get credentials only from a volumesnapshotclass
if present. This condition will never be met in case of VGS.

This patch adapts to code to fetch the credentials from the annotations
`AnnDeletionSecretRef*` if volumesnapshotclassname is not present.

Signed-off-by: Niraj Yadav <[email protected]>

Author: black-dragon74

pkg/sidecar-controller/snapshot_controller.go

@@ -290,6 +290,15 @@ func (ctrl *csiSnapshotSideCarController) checkandUpdateContentStatusOperation(c
 			}
 		}
 
+		// The VolumeSnapshotContents that are a member of a VolumeGroupSnapshot will always
+		// have Spec.VolumeSnapshotClassName unset, use annotations for secrets in such case.
+		if volumeGroupSnapshotMemberWithGroupSnapshotHandle {
+			snapshotterListCredentials, err = ctrl.GetCredentialsFromAnnotation(content)
+			if err != nil {
+				return content, fmt.Errorf("failed to get credentials from annotation for snapshot content %s: %v", content.Name, err)
+			}
+		}
+
 		readyToUse, creationTime, size, groupSnapshotID, err = ctrl.handler.GetSnapshotStatus(content, snapshotterListCredentials)
 		if err != nil {
 			klog.Errorf("checkandUpdateContentStatusOperation: failed to call get snapshot status to check whether snapshot is ready to use %q", err)