CRD updates to volumegroupsnapshots cannot be updated

[evilhamsterman]

What happened:

CRD version change to volumegroupsnapshots and related causes updates to the CRD to fail

kubectl appy --server-side -k external-snapshotter/client/config/crd/
customresourcedefinition.apiextensions.k8s.io/volumesnapshotclasses.snapshot.storage.k8s.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/volumesnapshotcontents.snapshot.storage.k8s.io serverside-applied
customresourcedefinition.apiextensions.k8s.io/volumesnapshots.snapshot.storage.k8s.io serverside-applied
Error from server (Invalid): CustomResourceDefinition.apiextensions.k8s.io "volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io" is invalid: status.storedVersions[0]: Invalid value: "v1alpha1": must appear in spec.versions
Error from server (Invalid): CustomResourceDefinition.apiextensions.k8s.io "volumegroupsnapshotcontents.groupsnapshot.storage.k8s.io" is invalid: status.storedVersions[0]: Invalid value: "v1alpha1": must appear in spec.versions
Error from server (Invalid): CustomResourceDefinition.apiextensions.k8s.io "volumegroupsnapshots.groupsnapshot.storage.k8s.io" is invalid: status.storedVersions[0]: Invalid value: "v1alpha1": must appear in spec.versions

What you expected to happen:

CRD updates to succeed

How to reproduce it:

Deploy CRDs from tag 8.1.1 and then try to update to 8.2.x

Anything else we need to know?:

According to the Kubernetes documentation you cannot simply remove a version you must have a period of time where you have both versions to allow for migration of objects. https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/

Environment:

• Driver version: 8.2.1
• Kubernetes version (use kubectl version): 1.32
• OS (e.g. from /etc/os-release): Ubuntu
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[evilhamsterman]

This is what I had to do to get it to apply since it's just a version bump not schema change

1. Copy v1alpha back into the crd
2. Set v1beta.served: true and v1beta.storage: true and v1alpha.storage: false
3. Apply the CRD
4. At this point migrate any resources to the new version, this could/should be done in the controller or can be done by users
5. Switch v1alpha1.served: false
6. Apply the CRD
7. If there are no errors patch status.storedVersions to only include v1beta1
8. Remove v1alpha1 from the crd
9. Apply the CRD

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten