Skip to content

Commit 17bcf29

Browse files
committed
chore: refactor pod and namespace under dashboards/resources
1 parent a7a949f commit 17bcf29

File tree

6 files changed

+10
-16
lines changed

6 files changed

+10
-16
lines changed

dashboards/resources/namespace.libsonnet

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
local g = import 'github.com/grafana/grafonnet/gen/grafonnet-latest/main.libsonnet';
21
local defaultQueries = import './queries/namespace.libsonnet';
32
local defaultVariables = import './variables/namespace.libsonnet';
3+
local g = import 'github.com/grafana/grafonnet/gen/grafonnet-latest/main.libsonnet';
44

55
local prometheus = g.query.prometheus;
66
local stat = g.panel.stat;
77
local table = g.panel.table;
88
local timeSeries = g.panel.timeSeries;
9-
local var = g.dashboard.variable;
109

1110
{
1211
local statPanel(title, unit, query) =
@@ -39,13 +38,13 @@ local var = g.dashboard.variable;
3938
'k8s-resources-namespace.json':
4039
// Allow overriding queries via $._queries.namespace, otherwise use default
4140
local queries = if std.objectHas($, '_queries') && std.objectHas($._queries, 'namespace')
42-
then $._queries.namespace
43-
else defaultQueries;
41+
then $._queries.namespace
42+
else defaultQueries;
4443

4544
// Allow overriding variables via $._variables.namespace, otherwise use default
4645
local variables = if std.objectHas($, '_variables') && std.objectHas($._variables, 'namespace')
47-
then $._variables.namespace($._config)
48-
else defaultVariables.namespace($._config);
46+
then $._variables.namespace($._config)
47+
else defaultVariables.namespace($._config);
4948

5049
local links = {
5150
pod: {

dashboards/resources/pod.libsonnet

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
local g = import 'github.com/grafana/grafonnet/gen/grafonnet-latest/main.libsonnet';
21
local defaultQueries = import './queries/pod.libsonnet';
32
local defaultVariables = import './variables/pod.libsonnet';
3+
local g = import 'github.com/grafana/grafonnet/gen/grafonnet-latest/main.libsonnet';
44

55
local prometheus = g.query.prometheus;
66
local table = g.panel.table;
77
local timeSeries = g.panel.timeSeries;
8-
local var = g.dashboard.variable;
98

109
{
1110
local tsPanel =
@@ -28,13 +27,13 @@ local var = g.dashboard.variable;
2827
'k8s-resources-pod.json':
2928
// Allow overriding queries via $._queries.pod, otherwise use default
3029
local queries = if std.objectHas($, '_queries') && std.objectHas($._queries, 'pod')
31-
then $._queries.pod
32-
else defaultQueries;
30+
then $._queries.pod
31+
else defaultQueries;
3332

3433
// Allow overriding variables via $._variables.pod, otherwise use default
3534
local variables = if std.objectHas($, '_variables') && std.objectHas($._variables, 'pod')
36-
then $._variables.pod($._config)
37-
else defaultVariables.pod($._config);
35+
then $._variables.pod($._config)
36+
else defaultVariables.pod($._config);
3837

3938
local panels = [
4039
tsPanel.new('CPU Usage')

dashboards/resources/queries/namespace.libsonnet

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,4 +131,3 @@
131131
storageReadPlusWriteBytes(config)::
132132
'sum by(pod) (rate(container_fs_reads_bytes_total{%(cadvisorSelector)s, %(diskDeviceSelector)s, %(containerfsSelector)s, %(clusterLabel)s="$cluster", namespace="$namespace"}[%(grafanaIntervalVar)s]) + rate(container_fs_writes_bytes_total{%(cadvisorSelector)s, %(diskDeviceSelector)s, %(containerfsSelector)s, %(clusterLabel)s="$cluster", namespace="$namespace"}[%(grafanaIntervalVar)s]))' % config,
133133
}
134-

dashboards/resources/queries/pod.libsonnet

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,4 +131,3 @@
131131
storageReadPlusWriteBytes(config)::
132132
'sum by(container) (rate(container_fs_reads_bytes_total{%(cadvisorSelector)s, %(diskDeviceSelector)s, %(containerfsSelector)s, %(clusterLabel)s="$cluster", namespace="$namespace", pod="$pod"}[%(grafanaIntervalVar)s]) + rate(container_fs_writes_bytes_total{%(cadvisorSelector)s, %(diskDeviceSelector)s, %(containerfsSelector)s, %(clusterLabel)s="$cluster", namespace="$namespace", pod="$pod"}[%(grafanaIntervalVar)s]))' % config,
133133
}
134-

dashboards/resources/variables/namespace.libsonnet

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,3 @@ local var = g.dashboard.variable;
4747
+ var.query.withSort(type='alphabetical'),
4848
},
4949
}
50-

dashboards/resources/variables/pod.libsonnet

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,3 @@ local var = g.dashboard.variable;
5959
+ var.query.withSort(type='alphabetical'),
6060
},
6161
}
62-

0 commit comments

Comments
 (0)