Skip to content

Commit 30d35ea

Browse files
committed
add tests
Signed-off-by: TheRealNoob <[email protected]>
1 parent e88580b commit 30d35ea

File tree

2 files changed

+35
-2
lines changed

2 files changed

+35
-2
lines changed

alerts/kubelet.libsonnet

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ local utils = import '../lib/utils.libsonnet';
3232
description: '{{ $labels.node }} has been unready for more than 15 minutes%s.' % [
3333
utils.ifShowMultiCluster($._config, ' on cluster {{ $labels.%(clusterLabel)s }}' % $._config),
3434
],
35-
summary: 'Schedulable Node is not ready.',
35+
summary: 'Node is not ready.',
3636
},
3737
'for': '15m',
3838
alert: 'KubeNodeNotReady',
@@ -98,7 +98,7 @@ local utils = import '../lib/utils.libsonnet';
9898
description: 'The readiness status of node {{ $labels.node }} has changed {{ $value }} times in the last 15 minutes%s.' % [
9999
utils.ifShowMultiCluster($._config, ' on cluster {{ $labels.%(clusterLabel)s }}' % $._config),
100100
],
101-
summary: 'Schedulable Node readiness status is flapping.',
101+
summary: 'Node readiness status is flapping.',
102102
},
103103
},
104104
{

tests.yaml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -570,8 +570,41 @@ tests:
570570

571571
- interval: 1m
572572
input_series:
573+
# node=minikube is uncordoned so we expect the alert to fire
573574
- series: 'kube_node_status_condition{condition="Ready",endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube",pod="kube-state-metrics-b894d84cc-d6htw",service="kube-state-metrics",status="true"}'
575+
values: '0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0'
576+
- series: 'kube_node_spec_unschedulable{endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube",pod="kube-state-metrics-b894d84cc-d6htw",service="kube-state-metrics",status="true"}'
577+
values: '0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0'
578+
# node=minikube2 is cordoned so we expect the alert to not fire
579+
- series: 'kube_node_status_condition{condition="Ready",endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube2",pod="kube-state-metrics-b894d84cc-f5e9f",service="kube-state-metrics"}'
580+
values: '0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0'
581+
- series: 'kube_node_spec_unschedulable{endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube2",pod="kube-state-metrics-b894d84cc-f5e9f",service="kube-state-metrics"}'
582+
values: '1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1'
583+
alert_rule_test:
584+
- eval_time: 18m
585+
alertname: KubeNodeNotReady
586+
exp_alerts:
587+
- exp_labels:
588+
cluster: kubernetes
589+
node: minikube
590+
severity: warning
591+
exp_annotations:
592+
summary: "Node is not ready."
593+
description: 'minikube has been unready for more than 15 minutes.'
594+
runbook_url: 'https://github.com/kubernetes-monitoring/kubernetes-mixin/tree/master/runbook.md#alert-name-kubenodenotready"'
595+
596+
- interval: 1m
597+
input_series:
598+
# node=minikube is uncordoned so we expect the alert to fire
599+
- series: 'kube_node_status_condition{condition="Ready",endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube",pod="kube-state-metrics-b894d84cc-d6htw",service="kube-state-metrics",status="true"}'
600+
values: '1 0 1 0 1 0 0 0 1 0 1 0 0 0 1 0 1 0 0 1'
601+
- series: 'kube_node_spec_unschedulable{endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube",pod="kube-state-metrics-b894d84cc-d6htw",service="kube-state-metrics",status="true"}'
602+
values: '0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0'
603+
# node=minikube2 is cordoned so we expect the alert to not fire
604+
- series: 'kube_node_status_condition{condition="Ready",endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube2",pod="kube-state-metrics-b894d84cc-f5e9f",service="kube-state-metrics",status="true"}'
574605
values: '1 0 1 0 1 0 0 0 1 0 1 0 0 0 1 0 1 0 0 1'
606+
- series: 'kube_node_spec_unschedulable{endpoint="https-main",cluster="kubernetes",instance="10.0.2.15:10250",job="kube-state-metrics",namespace="monitoring",node="minikube2",pod="kube-state-metrics-b894d84cc-f5e9f",service="kube-state-metrics"}'
607+
values: '1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1'
575608
alert_rule_test:
576609
- eval_time: 18m
577610
alertname: KubeNodeReadinessFlapping

0 commit comments

Comments
 (0)