fix: apiserver availability apiserver_request_sli_duration_seconds_count:increase30d (#998)

lorenzofelletti · web-flow · commit b726a916acea · 2024-12-16T18:42:36.000Z
* fix: double mutiplication (#2564)

* fix: expr string interpolation
diff --git a/rules/kube_apiserver-availability.libsonnet b/rules/kube_apiserver-availability.libsonnet
@@ -50,8 +50,8 @@
           {
             record: 'cluster_verb_scope:apiserver_request_sli_duration_seconds_count:increase%s' % SLODays,
             expr: |||
-              sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"} * 24 * %s)
-            ||| % [$._config.clusterLabel, SLODays, $._config.SLOs.apiserver.days],
+              sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"})
+            ||| % [$._config.clusterLabel, SLODays],
           },
           {
             record: 'apiserver_request:availability%s' % SLODays,

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@`
`50`	`50`	`{`
`51`	`51`	`record: 'cluster_verb_scope:apiserver_request_sli_duration_seconds_count:increase%s' % SLODays,`
`52`	`52`	`expr: \|\|\|`
`53`		`- sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"} * 24 * %s)`
`54`		`- \|\|\| % [$._config.clusterLabel, SLODays, $._config.SLOs.apiserver.days],`
	`53`	`+ sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"})`
	`54`	`+ \|\|\| % [$._config.clusterLabel, SLODays],`
`55`	`55`	`},`
`56`	`56`	`{`
`57`	`57`	`record: 'apiserver_request:availability%s' % SLODays,`