fix "smelly selector" syntax preference

TheRealNoob · TheRealNoob · commit d13e847b1afd · 2025-02-07T12:13:59.000-06:00
this turned out to be a good chance because it made me realize there was an additional label value here that wasn't be handled.

Signed-off-by: TheRealNoob &lt;mike1118@live.com&gt;
diff --git a/alerts/kubelet.libsonnet b/alerts/kubelet.libsonnet
@@ -43,7 +43,7 @@ local utils = import '../lib/utils.libsonnet';
           {
             alert: 'KubeNodePressure',
             expr: |||
-              kube_node_status_condition{%(kubeStateMetricsSelector)s,condition=~".+Pressure",status="true"} == 1
+              kube_node_status_condition{%(kubeStateMetricsSelector)s,condition=!"Ready",status="true"} == 1
               and on (%(clusterLabel)s, node)
               kube_node_spec_unschedulable{%(kubeStateMetricsSelector)s} == 0
             ||| % $._config,

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ local utils = import '../lib/utils.libsonnet';`
`43`	`43`	`{`
`44`	`44`	`alert: 'KubeNodePressure',`
`45`	`45`	`expr: \|\|\|`
`46`		`- kube_node_status_condition{%(kubeStateMetricsSelector)s,condition=~".+Pressure",status="true"} == 1`
	`46`	`+ kube_node_status_condition{%(kubeStateMetricsSelector)s,condition=!"Ready",status="true"} == 1`
`47`	`47`	`and on (%(clusterLabel)s, node)`
`48`	`48`	`kube_node_spec_unschedulable{%(kubeStateMetricsSelector)s} == 0`
`49`	`49`	`\|\|\| % $._config,`