[Bug]: [Dashboard] USE Method / Node(Windows) wrong queries for multiple choices variable (instance)

[mkozikowsk]

What happened?

Queries expect the single value for instance varaible:
For example query from the CPU Utilisation panel:
node:windows_node_cpu_utilisation:avg1m{cluster="$cluster", instance="$instance"}

Grafana automatically constructs the value1|...|valueN regexp for the $instance variable so the query should look like this:

node:windows_node_cpu_utilisation:avg1m{cluster="$cluster", instance=~"$instance"}

=~: Select labels that regex-match the provided string

Please provide any helpful snippets.

No response

What parts of the codebase are affected?

Dashboards

I agree to the following terms:

• I agree to follow this project's Code of Conduct.
• I have filled out all the required information above to the best of my ability.
• I have searched the issues of this repository and believe that this is not a duplicate.
• I have confirmed this bug exists in the default branch of the repository, as of the latest commit at the time of submission.

[skl]

Thanks for raising @mkozikowsk! I see 16 matches for instance=" in dashboards/windows.libsonnet, which means there are a bunch of panels expecting only a single instance value.

Seems to me that either the instance dashboard variable needs multi-select disabling or all of these panels should be updated to handle multiple instances. If the latter, the queries need to be checked as some aggregations probably need labels adding (e.g. cluster and/or instance).

[github-actions]

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

• The stale label will be removed if there is new activity
• The issue will be closed in 7 days if there is no new activity
• Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

[skl]

Fixed by #1013