Skip to content

[Bug]: Pint lint failure on CPUThrottlingHigh alert #985

@skl

Description

@skl

What happened?

Pint lint failure, the docs on this check can be found here:

Please provide any helpful snippets.

prometheus_alerts.yaml:342-346 Warning: Aggregation using `without()` can be fragile when used inside binary expression because both sides must have identical sets of labels to produce any results, adding or removing labels to metrics used here can easily break the query, consider aggregating using `by()` to ensure consistent labels. (promql/fragile)
 342 |     "expr": |
 343 |       sum(increase(container_cpu_cfs_throttled_periods_total{container!="", job="cadvisor", }[5m])) without (id, metrics_path, name, image, endpoint, job, node)
 344 |         /
 345 |       sum(increase(container_cpu_cfs_periods_total{job="cadvisor", }[5m])) without (id, metrics_path, name, image, endpoint, job, node)
 346 |         > ( 25 / 100 )
make: *** [Makefile:80: pint-lint] Error 1

Originating PR:

What parts of the codebase are affected?

Alerts

I agree to the following terms:

  • I agree to follow this project's Code of Conduct.
  • I have filled out all the required information above to the best of my ability.
  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have confirmed this bug exists in the default branch of the repository, as of the latest commit at the time of submission.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingkeepaliveUse to prevent automatic closing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions