From a9397d5b33c07accf5c36381b39951cd95cd44a6 Mon Sep 17 00:00:00 2001 From: Lorenzo Felletti Date: Sun, 15 Dec 2024 16:32:08 +0000 Subject: [PATCH 1/2] fix: double mutiplication (#2564) --- rules/kube_apiserver-availability.libsonnet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/kube_apiserver-availability.libsonnet b/rules/kube_apiserver-availability.libsonnet index c7a0378e9..93bb3ece0 100644 --- a/rules/kube_apiserver-availability.libsonnet +++ b/rules/kube_apiserver-availability.libsonnet @@ -50,7 +50,7 @@ { record: 'cluster_verb_scope:apiserver_request_sli_duration_seconds_count:increase%s' % SLODays, expr: ||| - sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"} * 24 * %s) + sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"}) ||| % [$._config.clusterLabel, SLODays, $._config.SLOs.apiserver.days], }, { From 4574bc66256eff6a86c47fab7480e60b20117dd7 Mon Sep 17 00:00:00 2001 From: Lorenzo Felletti Date: Mon, 16 Dec 2024 12:47:48 +0000 Subject: [PATCH 2/2] fix: expr string interpolation --- rules/kube_apiserver-availability.libsonnet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/kube_apiserver-availability.libsonnet b/rules/kube_apiserver-availability.libsonnet index 93bb3ece0..25a63309a 100644 --- a/rules/kube_apiserver-availability.libsonnet +++ b/rules/kube_apiserver-availability.libsonnet @@ -51,7 +51,7 @@ record: 'cluster_verb_scope:apiserver_request_sli_duration_seconds_count:increase%s' % SLODays, expr: ||| sum by (%s, verb, scope) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase%s{le="+Inf"}) - ||| % [$._config.clusterLabel, SLODays, $._config.SLOs.apiserver.days], + ||| % [$._config.clusterLabel, SLODays], }, { record: 'apiserver_request:availability%s' % SLODays,