Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 0749dc0

Browse files
committed
Revert "use bash for the makefile shell"
This reverts commit 132a381. The initial commit doesn't mention this, but the pull request has the error messages this was avoiding [1]: > make is using sh on Jenkins by default. This tweak sets the shell to > bash to fix the following error on make check: > > 05:22:18 [1650506.967906] golang[6]: /bin/sh: 1: read: arg count > 05:22:18 [1650507.054205] golang[6]: /bin/sh: 1: [: 2: unexpected operator Instead of forcing Bash, we should fix those issues to stay POSIX-compliant. [1]: #870 (comment)
1 parent 957d155 commit 0749dc0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ export CGO_ENABLED:=0
22
export GOARCH:=amd64
33
export PATH:=$(PATH):$(PWD)
44

5-
SHELL:=$(shell which bash)
65
LOCAL_OS:=$(shell uname | tr A-Z a-z)
76
GOFILES:=$(shell find . -name '*.go' | grep -v -E '(./vendor)')
87
LDFLAGS=-X github.com/kubernetes-incubator/bootkube/pkg/version.Version=$(shell $(CURDIR)/build/git-version.sh)

0 commit comments

Comments
 (0)