Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 64c66a3

Browse files
authored
Merge pull request #784 from diegs/checkpointer-e2e
e2e: make checkpointer tests more robust.
2 parents a5610c9 + 0955615 commit 64c66a3

File tree

10 files changed

+349
-262
lines changed

10 files changed

+349
-262
lines changed

cmd/checkpoint/README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,15 @@ Once it reaches the API server and finds out that it's no longer being scheduled
8888
### RBAC Requirements
8989

9090
By default, the pod checkpoint runs with service account credentials, checkpointing its own
91-
service account secret for reboots. That service account must be bound to a ClusterRole that
92-
lets the pod checkpoint watch for Pods with the checkpoint annotation, then save ConfigMaps and
93-
Secrets referenced by those Pods.
91+
service account secret for reboots. That service account must be bound to a Role that lets the
92+
pod checkpoint watch for Pods with the checkpoint annotation, then save ConfigMaps and Secrets
93+
referenced by those Pods.
9494

9595
```yaml
96-
kind: ClusterRole
96+
kind: Role
9797
metadata:
9898
name: pod-checkpointer
99+
namespace: kube-system
99100
rules:
100101
- apiGroups: [""] # "" indicates the core API group
101102
resources: ["pods"]
@@ -104,6 +105,3 @@ rules:
104105
resources: ["secrets", "configmaps"]
105106
verbs: ["get"]
106107
```
107-
108-
Currently the pod checkpoint watches all pods in all namespaces, and requires a ClusterRole and
109-
ClusterRoleBinding. In the future the pod checkpoint may be restricted to `kube-system`.

0 commit comments

Comments
 (0)