Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 8afee1f

Browse files
Patrick BaxterYifan Gu
authored andcommitted
hack/quickstart: apiserver flag not needed
The --require-kubeconfig flag is needed if we remove the apiserver flag because of a bug that persisted into 1.5. This should eventually default to true.
1 parent 0c96053 commit 8afee1f

File tree

3 files changed

+6
-22
lines changed

3 files changed

+6
-22
lines changed

hack/quickstart/init-worker.sh

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,33 +13,17 @@ function usage() {
1313
exit 1
1414
}
1515

16-
function extract_master_endpoint (){
17-
grep 'certificate-authority-data' ${KUBECONFIG} | awk '{print $2}' | base64 -d > /home/core/ca.crt
18-
grep 'client-certificate-data' ${KUBECONFIG} | awk '{print $2}'| base64 -d > /home/core/client.crt
19-
grep 'client-key-data' ${KUBECONFIG} | awk '{print $2}'| base64 -d > /home/core/client.key
20-
21-
MASTER_PUB="$(awk '/server:/ {print $2}' ${KUBECONFIG} | awk -F/ '{print $3}' | awk -F: '{print $1}')"
22-
# TODO (aaron): The -k was added with the gce conformance tests - figure out why it's needed here.
23-
# The certs are seemingly signed correctly, but says no SAN for MASTER_PUB
24-
MASTER_PRIV=$(curl -k https://${MASTER_PUB}:443/api/v1/namespaces/default/endpoints/kubernetes \
25-
--cacert /home/core/ca.crt --cert /home/core/client.crt --key /home/core/client.key \
26-
| jq -r '.subsets[0].addresses[0].ip')
27-
rm -f /home/core/client.crt /home/core/client.key
28-
}
29-
3016
# Initialize a worker node
3117
function init_worker_node() {
32-
extract_master_endpoint
3318

3419
# Setup kubeconfig
3520
mkdir -p /etc/kubernetes
3621
cp ${KUBECONFIG} /etc/kubernetes/kubeconfig
37-
# Pulled out of the kubeconfig in extract_master_endpoint. Other installations should
38-
# place the root CA here manually.
39-
mv /home/core/ca.crt /etc/kubernetes/ca.crt
22+
# Pulled out of the kubeconfig. Other installations should place the root
23+
# CA here manually.
24+
grep 'certificate-authority-data' ${KUBECONFIG} | awk '{print $2}' | base64 -d > /etc/kubernetes/ca.crt
4025

41-
sed "s/{{apiserver}}/${MASTER_PRIV}/" /home/core/kubelet.worker > /etc/systemd/system/kubelet.service
42-
rm /home/core/kubelet.worker
26+
mv /home/core/kubelet.worker /etc/systemd/system/kubelet.service
4327

4428
# Start services
4529
systemctl daemon-reload

hack/quickstart/kubelet.master

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ ExecStartPre=/bin/mkdir -p /srv/kubernetes/manifests
1313
ExecStartPre=/bin/mkdir -p /var/lib/cni
1414
ExecStartPre=-/usr/bin/rkt rm --uuid-file=/var/run/kubelet-pod.uuid
1515
ExecStart=/usr/lib/coreos/kubelet-wrapper \
16-
--api-servers=https://${COREOS_PRIVATE_IPV4}:443 \
1716
--kubeconfig=/etc/kubernetes/kubeconfig \
17+
--require-kubeconfig \
1818
--client-ca-file=/etc/kubernetes/ca.crt \
1919
--anonymous-auth=false \
2020
--cni-conf-dir=/etc/kubernetes/cni/net.d \

hack/quickstart/kubelet.worker

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ ExecStartPre=/bin/mkdir -p /etc/kubernetes/cni/net.d
1111
ExecStartPre=/bin/mkdir -p /var/lib/cni
1212
ExecStartPre=-/usr/bin/rkt rm --uuid-file=/var/run/kubelet-pod.uuid
1313
ExecStart=/usr/lib/coreos/kubelet-wrapper \
14-
--api-servers=https://{{apiserver}}:443 \
1514
--kubeconfig=/etc/kubernetes/kubeconfig \
15+
--require-kubeconfig \
1616
--client-ca-file=/etc/kubernetes/ca.crt \
1717
--anonymous-auth=false \
1818
--cni-conf-dir=/etc/kubernetes/cni/net.d \

0 commit comments

Comments
 (0)