Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 9792a74

Browse files
authored
Merge pull request #971 from ericchiang/rm-kubernetes-import
pkg/checkpoint: remove k8s.io/kubernetes import
2 parents 37ae79c + 84e7b85 commit 9792a74

File tree

59 files changed

+24
-106249
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+24
-106249
lines changed

Gopkg.lock

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ revision = "kubernetes-1.9.3"
1919
[[constraint]]
2020
name = "k8s.io/client-go"
2121
revision = "kubernetes-1.9.3"
22-
[[constraint]]
23-
# Required for CRI integration
24-
name = "k8s.io/kubernetes"
25-
version = "v1.9.3"
2622

2723
[[constraint]]
2824
name = "github.com/coreos/etcd"

bill-of-materials.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -393,14 +393,5 @@
393393
"confidence": 1
394394
}
395395
]
396-
},
397-
{
398-
"project": "k8s.io/kubernetes/pkg",
399-
"licenses": [
400-
{
401-
"type": "Apache License 2.0",
402-
"confidence": 1
403-
}
404-
]
405396
}
406397
]

pkg/checkpoint/internal/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Copied from pkg/kubelet/util to prevent importing kubernetes
2+
3+
```
4+
wget https://raw.githubusercontent.com/kubernetes/kubernetes/v1.10.2/pkg/kubelet/util/util_unix.go
5+
wget https://raw.githubusercontent.com/kubernetes/kubernetes/v1.10.2/pkg/kubelet/util/util.go
6+
```

vendor/k8s.io/kubernetes/pkg/kubelet/util/util.go renamed to pkg/checkpoint/internal/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
*/
1616

17-
package util
17+
package internal
1818

1919
import (
2020
"fmt"

vendor/k8s.io/kubernetes/pkg/kubelet/util/util_unix.go renamed to pkg/checkpoint/internal/util_unix.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ See the License for the specific language governing permissions and
1616
limitations under the License.
1717
*/
1818

19-
package util
19+
package internal
2020

2121
import (
2222
"fmt"

pkg/checkpoint/runtime_service.go

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,19 @@ import (
88
"google.golang.org/grpc"
99
"k8s.io/api/core/v1"
1010
"k8s.io/apimachinery/pkg/types"
11-
kubelettypes "k8s.io/kubernetes/pkg/kubelet/types"
12-
"k8s.io/kubernetes/pkg/kubelet/util"
1311

1412
"github.com/kubernetes-incubator/bootkube/pkg/checkpoint/cri/v1alpha1"
1513
"github.com/kubernetes-incubator/bootkube/pkg/checkpoint/cri/v1alpha2"
14+
"github.com/kubernetes-incubator/bootkube/pkg/checkpoint/internal"
15+
)
16+
17+
// Copied from "k8s.io/kubernetes/pkg/kubelet/types"
18+
const (
19+
kubernetesPodNameLabel = "io.kubernetes.pod.name"
20+
kubernetesPodNamespaceLabel = "io.kubernetes.pod.namespace"
21+
kubernetesPodUIDLabel = "io.kubernetes.pod.uid"
22+
kubernetesContainerNameLabel = "io.kubernetes.container.name"
23+
kubernetesContainerTypeLabel = "io.kubernetes.container.type"
1624
)
1725

1826
type remoteRuntimeService struct {
@@ -23,7 +31,7 @@ type remoteRuntimeService struct {
2331

2432
func newRemoteRuntimeService(endpoint string, connectionTimeout time.Duration) (*remoteRuntimeService, error) {
2533
glog.Infof("Connecting to runtime service %s", endpoint)
26-
addr, dialer, err := util.GetAddressAndDialer(endpoint)
34+
addr, dialer, err := internal.GetAddressAndDialer(endpoint)
2735
if err != nil {
2836
return nil, err
2937
}
@@ -74,12 +82,12 @@ func (r *remoteRuntimeService) localRunningPods() map[string]*v1.Pod {
7482
// Add all pods that containers are apart of
7583
for _, c := range containers {
7684

77-
podName := c.Labels[kubelettypes.KubernetesPodNamespaceLabel] + "/" + c.Labels[kubelettypes.KubernetesPodNameLabel]
85+
podName := c.Labels[kubernetesPodNamespaceLabel] + "/" + c.Labels[kubernetesPodNameLabel]
7886
if _, ok := pods[podName]; !ok {
7987
p := &v1.Pod{}
80-
p.UID = types.UID(c.Labels[kubelettypes.KubernetesPodUIDLabel])
81-
p.Name = c.Labels[kubelettypes.KubernetesPodNameLabel]
82-
p.Namespace = c.Labels[kubelettypes.KubernetesPodNamespaceLabel]
88+
p.UID = types.UID(c.Labels[kubernetesPodUIDLabel])
89+
p.Name = c.Labels[kubernetesPodNameLabel]
90+
p.Namespace = c.Labels[kubernetesPodNamespaceLabel]
8391

8492
pods[podName] = p
8593
}

vendor/k8s.io/kubernetes/.bazelrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

vendor/k8s.io/kubernetes/.kazelcfg.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

vendor/k8s.io/kubernetes/BUILD.bazel

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)