fix: unexport local variables

Signed-off-by: Chris Privitere <[email protected]>

Author: cprivitere

cmd/ci-clean/main.go

@@ -33,11 +33,11 @@ import (
 )
 
 const (
-	AuthTokenEnvVar = "PACKET_API_KEY" //nolint:gosec
-	ProjectIDEnvVar = "PROJECT_ID"
+	authTokenEnvVar = "PACKET_API_KEY" //nolint:gosec
+	projectIDEnvVar = "PROJECT_ID"
 )
 
-var ErrMissingRequiredEnvVar = errors.New("required environment variable not set")
+var errMissingRequiredEnvVar = errors.New("required environment variable not set")
 
 func main() {
 	rand.Seed(time.Now().UTC().UnixNano())
@@ -46,14 +46,14 @@ func main() {
 		Use:   "ci-clean",
 		Short: "Clean up any stray resources in CI",
 		RunE: func(cmd *cobra.Command, args []string) error {
-			metalAuthToken := os.Getenv(AuthTokenEnvVar)
+			metalAuthToken := os.Getenv(authTokenEnvVar)
 			if metalAuthToken == "" {
-				return fmt.Errorf("%s: %w", AuthTokenEnvVar, ErrMissingRequiredEnvVar)
+				return fmt.Errorf("%s: %w", authTokenEnvVar, errMissingRequiredEnvVar)
 			}
 
-			metalProjectID := os.Getenv(ProjectIDEnvVar)
+			metalProjectID := os.Getenv(projectIDEnvVar)
 			if metalProjectID == "" {
-				return fmt.Errorf("%s: %w", ProjectIDEnvVar, ErrMissingRequiredEnvVar)
+				return fmt.Errorf("%s: %w", projectIDEnvVar, errMissingRequiredEnvVar)
 			}
 
 			return cleanup(context.Background(), metalAuthToken, metalProjectID) //nolint:wrapcheck

controllers/packetmachine_controller.go

@@ -53,9 +53,9 @@ const (
 )
 
 var (
-	ErrMissingDevice = errors.New("machine does not exist")
-	ErrFacilityMatch = errors.New("instance facility does not match machine facility")
-	ErrMetroMatch    = errors.New("instance metro does not match machine metro")
+	errMissingDevice = errors.New("machine does not exist")
+	errFacilityMatch = errors.New("instance facility does not match machine facility")
+	errMetroMatch    = errors.New("instance metro does not match machine metro")
 )
 
 // PacketMachineReconciler reconciles a PacketMachine object
@@ -425,11 +425,11 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s
 	deviceMetro := dev.Metro.Code
 
 	if machineScope.PacketMachine.Spec.Facility != "" && machineScope.PacketMachine.Spec.Facility != *deviceFacility {
-		return ctrl.Result{}, fmt.Errorf("%w: %s != %s", ErrFacilityMatch, machineScope.PacketMachine.Spec.Facility, *deviceFacility)
+		return ctrl.Result{}, fmt.Errorf("%w: %s != %s", errFacilityMatch, machineScope.PacketMachine.Spec.Facility, *deviceFacility)
 	}
 
 	if machineScope.PacketMachine.Spec.Metro != "" && machineScope.PacketMachine.Spec.Metro != *deviceMetro {
-		return ctrl.Result{}, fmt.Errorf("%w: %s != %s", ErrMetroMatch, machineScope.PacketMachine.Spec.Facility, *deviceMetro)
+		return ctrl.Result{}, fmt.Errorf("%w: %s != %s", errMetroMatch, machineScope.PacketMachine.Spec.Facility, *deviceMetro)
 	}
 
 	return result, nil
@@ -494,7 +494,7 @@ func (r *PacketMachineReconciler) reconcileDelete(ctx context.Context, machineSc
 	// We should never get there but this is a safetly check
 	if device == nil {
 		controllerutil.RemoveFinalizer(packetmachine, infrav1.MachineFinalizer)
-		return ctrl.Result{}, fmt.Errorf("%w: %s", ErrMissingDevice, packetmachine.Name)
+		return fmt.Errorf("%w: %s", errMissingDevice, packetmachine.Name)
 	}
 
 	apiRequest := r.PacketClient.DevicesApi.DeleteDevice(ctx, device.GetId()).ForceDelete(force)

pkg/cloud/packet/util.go

@@ -21,7 +21,7 @@ import (
 )
 
 const (
-	MachineUIDTag = "cluster-api-provider-packet:machine-uid"
+	machineUIDTag = "cluster-api-provider-packet:machine-uid"
 	clusterIDTag  = "cluster-api-provider-packet:cluster-id"
 	namespaceTag  = "cluster-api-provider-packet:namespace"
 )