chore: fix linting issues

Signed-off-by: Chris Privitere <[email protected]>

Author: cprivitere

api/v1beta1/packetcluster_webhook.go

@@ -94,7 +94,7 @@ func (c *PacketCluster) ValidateUpdate(oldRaw runtime.Object) (admission.Warning
 	}
 
 	// Must have only one of Metro or Facility
-	if len(c.Spec.Facility) > 0 && len(c.Spec.Metro) > 0 {
+	if c.Spec.Facility != "" && c.Spec.Metro != "" {
 		allErrs = append(allErrs,
 			field.Invalid(field.NewPath("spec", "Facility"),
 				c.Spec.Facility, "Metro and Facility are mutually exclusive, Metro is recommended"),

api/v1beta1/packetmachine_webhook.go

@@ -53,7 +53,7 @@ func (m *PacketMachine) ValidateUpdate(old runtime.Object) (admission.Warnings,
 	var allErrs field.ErrorList
 
 	// Must have only one of Metro or Facility specified
-	if len(m.Spec.Facility) > 0 && len(m.Spec.Metro) > 0 {
+	if m.Spec.Facility != "" && m.Spec.Metro != "" {
 		allErrs = append(allErrs,
 			field.Invalid(field.NewPath("spec", "Facility"),
 				m.Spec.Facility, "Metro and Facility field are mutually exclusive"),

cmd/ci-clean/main.go

@@ -43,7 +43,7 @@ func main() {
 	rootCmd := &cobra.Command{ //nolint:exhaustivestruct
 		Use:   "ci-clean",
 		Short: "Clean up any stray resources in CI",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			metalAuthToken := os.Getenv(authTokenEnvVar)
 			if metalAuthToken == "" {
 				return fmt.Errorf("%s: %w", authTokenEnvVar, errMissingRequiredEnvVar)

controllers/packetcluster_controller.go

@@ -116,7 +116,7 @@ func (r *PacketClusterReconciler) reconcileNormal(ctx context.Context, clusterSc
 	packetCluster := clusterScope.PacketCluster
 
 	switch {
-	case packetCluster.Spec.VIPManager == "EMLB":
+	case packetCluster.Spec.VIPManager == emlb.EMLBVIPID:
 		if !packetCluster.Spec.ControlPlaneEndpoint.IsValid() {
 			// Create new EMLB object
 			lb := emlb.NewEMLB(r.PacketClient.GetConfig().DefaultHeader["X-Auth-Token"], packetCluster.Spec.ProjectID, packetCluster.Spec.Metro)
@@ -134,7 +134,7 @@ func (r *PacketClusterReconciler) reconcileNormal(ctx context.Context, clusterSc
 		}
 	}
 
-	if packetCluster.Spec.VIPManager != "EMLB" {
+	if packetCluster.Spec.VIPManager != emlb.EMLBVIPID {
 		ipReserv, err := r.PacketClient.GetIPByClusterIdentifier(ctx, clusterScope.Namespace(), clusterScope.Name(), packetCluster.Spec.ProjectID)
 		switch {
 		case errors.Is(err, packet.ErrControlPlanEndpointNotFound):

controllers/packetmachine_controller.go

@@ -367,7 +367,7 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s
 					addrs = append(addrs, a)
 				}
 				controlPlaneEndpointAddress = controlPlaneEndpoint.GetAddress()
-			case machineScope.PacketCluster.Spec.VIPManager == "EMLB":
+			case machineScope.PacketCluster.Spec.VIPManager == emlb.EMLBVIPID:
 				controlPlaneEndpointAddress = machineScope.Cluster.Spec.ControlPlaneEndpoint.Host
 				cpemLBConfig = "emlb:///" + machineScope.PacketCluster.Spec.Metro
 				emlbID = machineScope.PacketCluster.Annotations["equinix.com/loadbalancerID"]
@@ -440,7 +440,7 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s
 					return ctrl.Result{RequeueAfter: time.Second * 20}, nil
 				}
 			}
-		case machineScope.PacketCluster.Spec.VIPManager == "EMLB":
+		case machineScope.PacketCluster.Spec.VIPManager == emlb.EMLBVIPID:
 			if machineScope.IsControlPlane() {
 				// Create new EMLB object
 				lb := emlb.NewEMLB(r.PacketClient.GetConfig().DefaultHeader["X-Auth-Token"], machineScope.PacketCluster.Spec.ProjectID, machineScope.PacketCluster.Spec.Metro)

internal/emlb/emlb.go

@@ -49,6 +49,8 @@ const (
 	loadBalancerPoolIDAnnotation = "equinix.com/loadbalancerpoolID"
 	// loadBalancerPoolOriginIDAnnotation is the anotation key representing the origin ID of a PacketMachine.
 	loadBalancerOriginIDAnnotation = "equinix.com/loadbalanceroriginID"
+	// EMLBVIPID is the stringused to refer to the EMLB load balancer and VIP Manager type.
+	EMLBVIPID = "EMLB"
 )
 
 var lbMetros = map[string]string{