Update logic to only permit one of metro or facility

Signed-off-by: Chris Privitere <[email protected]>

Author: cprivitere

api/v1beta1/packetcluster_webhook.go

@@ -88,14 +88,22 @@ func (c *PacketCluster) ValidateUpdate(oldRaw runtime.Object) error {
 		)
 	}
 
-	// Must have either one of Metro or Facility
+	// Must have at least Metro or Facility specified
 	if len(c.Spec.Facility) == 0 && len(c.Spec.Metro) == 0 {
 		allErrs = append(allErrs,
 			field.Invalid(field.NewPath("spec", "Metro"),
 				c.Spec.Metro, "field is required when Facility is not set"),
 		)
 	}
 
+	// Must have only one of Metro or Facility
+	if len(c.Spec.Facility) > 0 && len(c.Spec.Metro) > 0 {
+		allErrs = append(allErrs,
+			field.Invalid(field.NewPath("spec", "Metro"),
+				c.Spec.Metro, "field and Facility field are mutually exclusive"),
+		)
+	}
+
 	if len(allErrs) == 0 {
 		return nil
 	}

api/v1beta1/packetmachine_webhook.go

@@ -60,6 +60,14 @@ func (m *PacketMachine) ValidateUpdate(old runtime.Object) error {
 	machineLog.Info("validate update", "name", m.Name)
 	var allErrs field.ErrorList
 
+	// Must have only one of Metro or Facility specified
+	if len(m.Spec.Facility) > 0 && len(m.Spec.Metro) > 0 {
+		allErrs = append(allErrs,
+			field.Invalid(field.NewPath("spec", "Metro"),
+				m.Spec.Metro, "field and Facility field are mutually exclusive"),
+		)
+	}
+
 	newPacketMachine, err := runtime.DefaultUnstructuredConverter.ToUnstructured(m)
 	if err != nil {
 		allErrs = append(allErrs,