Health computation should ignore flakes

lavalamp · lavalamp · commit 098a2c3087a1 · 2016-06-10T17:02:57.000-07:00
diff --git a/mungegithub/mungers/submit-queue.go b/mungegithub/mungers/submit-queue.go
@@ -434,7 +434,8 @@ func (sq *SubmitQueue) updateHealth() {
 		Jobs:    map[string]bool{},
 	}
 	for job, status := range sq.e2e.GetBuildStatus() {
-		newEntry.Jobs[job] = status.Status == "Stable"
+		// Ignore flakes.
+		newEntry.Jobs[job] = status.Status != "Not Stable"
 	}
 	sq.healthHistory = append(sq.healthHistory, newEntry)
 	// Now compute the health structure so we don't have to do it on page load

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,8 @@ func (sq *SubmitQueue) updateHealth() {`
`434`	`434`	`Jobs: map[string]bool{},`
`435`	`435`	`}`
`436`	`436`	`for job, status := range sq.e2e.GetBuildStatus() {`
`437`		`- newEntry.Jobs[job] = status.Status == "Stable"`
	`437`	`+ // Ignore flakes.`
	`438`	`+ newEntry.Jobs[job] = status.Status != "Not Stable"`
`438`	`439`	`}`
`439`	`440`	`sq.healthHistory = append(sq.healthHistory, newEntry)`
`440`	`441`	`// Now compute the health structure so we don't have to do it on page load`